Skip to content

fix: fold exprs within tuple_map evaluation #5877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-sixty merged 3 commits into from
May 12, 2026
Merged

fix: fold exprs within tuple_map evaluation #5877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
919abc6
fix: fold exprs within tuple_map
kgutwin May 8, 2026
c7cd201
test: add tuple_map test
kgutwin May 11, 2026
6a43f12
fix: propagate fold error
kgutwin May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions prqlc/prqlc/src/semantic/resolver/transforms.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,12 +328,12 @@ impl Resolver<'_> {
let list_items = list_items
.into_iter()
.map(|item| {
Expr::new(ExprKind::FuncCall(FuncCall::new_simple(
self.fold_expr(Expr::new(ExprKind::FuncCall(FuncCall::new_simple(
func.clone(),
vec![item],
)))
))))
})
.collect_vec();
.collect::<Result<Vec<_>>>()?;

return Ok(Expr {
kind: ExprKind::Tuple(list_items),
Expand Down
19 changes: 19 additions & 0 deletions prqlc/prqlc/tests/integration/sql.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7275,3 +7275,22 @@ fn test_partial_application_of_transform() {
10
");
}

#[test]
fn test_tuple_map() {
assert_snapshot!(compile(r###"
let add_four = func a -> a + 4

from foo
select {x, y}
derive (tuple_map add_four foo.*)
"###).unwrap(), @"
SELECT
x,
y,
x + 4,
y + 4
FROM
foo
");
}
Loading