improve(plan): warn when a plan's sale is a large share of CX volume - #478
Open
Raukk wants to merge 2 commits into
Open
improve(plan): warn when a plan's sale is a large share of CX volume#478Raukk wants to merge 2 commits into
Raukk wants to merge 2 commits into
Conversation
Flags material I/O outputs whose daily sale is a large share of the sell exchange's 7d/30d traded volume, or lands on an illiquid market. Thresholds are user preferences (yellow 5% / red 15% by default). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PFsCfBfPMjbxDYBoh65xYC
👷 Deploy request for prunplanner-preview pending review.Visit the deploys page to approve it
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 46 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PFsCfBfPMjbxDYBoh65xYC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a warning under each output row of the plan material I/O table showing what share of the sell exchange's traded volume the plan's daily surplus represents — e.g. "6.1% of AI1 7D vol". The row turns yellow/red at user-configurable thresholds (defaults 5% / 15%, new settings under Preferences), checks both the 7d and 30d windows (the worse one colours the row), and flags exchanges that barely trade at all. The sell exchange comes from the plan's CX configuration's empire SELL/BOTH preference, falling back to UNIVERSE.
Goal: catch "this plan's numbers assume selling volume the market can't absorb" before a player builds it. Warns only — nothing is blocked and calculations are unchanged.
As always, let me know if I messed anything up.