📋 docs(swift-audit): correct parity matrix gaps and stale counts - #2651
Merged
Conversation
Release: development → main
Three corrections to the 2026-05-20 SwiftUI/Expo parity matrix: 1. Add the missing Purchases / RevenueCat row. Expo has the integration scaffolded (features/purchases/, 16 files) with no Swift counterpart, but this is scored `deferred for all` rather than a gap: the Expo-side setup is not complete, no feature is gated today, and Swift work is deliberately sequenced after Expo's setup finishes. Notes that `enableRevenueCat` in AppFeatureFlags.swift is a generated mirror of packages/config/src/config.ts with no Swift consumers, so it gates nothing. 2. Add a `deferred by decision` line to the status totals, and a `deferred for all` entry to the legend so the status is defined. 3. Correct the macOS XCUITest counts. The audit claimed "13 new MacOS test classes, 1492 lines"; Tests/PackRatMacUITests/ actually holds 7 files, and PR #2627 retires 5 of them for a PackRatMacOSUITests bundle that currently contains only Info.plist. Also clarifies that UITestFeatureFlags.swift is test infrastructure, not flag coverage. Adds a dated amendment header recording the staleness (335 commits to apps/expo vs 107 to apps/swift since the audit) and the matrix's capability-level granularity limit.
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe feature parity matrix records August 5 audit amendments, deferred Purchases / RevenueCat support, corrected macOS UI-test counts, revised test coverage, and a staleness caveat. ChangesParity matrix audit
Estimated code review effort: 1 (Trivial) | ~3 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three corrections to
docs/audits/2026-05-20-feature-parity-matrix.md, found while auditing how far the Swift iOS app is from parity with Expo.1. Added the missing Purchases / RevenueCat row.
apps/expo/features/purchases/(16 files —lib/revenueCat.ts, 10 hooks,EarlyAccessGate,CustomerCenter) had no counterpart row in the matrix at all, so the "expo-only gaps: 0 user-facing" total was computed over a table that never considered it.Scored
deferred for all, not a gap, and not a swap blocker — per product decision: the Expo-side setup is not fully complete, no feature is being gated today, and Swift work is intentionally sequenced after Expo's setup finishes. This is explicitly not a parity target until then.The row also records that
enableRevenueCatinAppFeatureFlags.swiftis a@generatedmirror ofpackages/config/src/config.tsand has no Swift consumers — it gates nothing.2. Status totals + legend. Added a
deferred by decisionline to the totals, and adeferred for allentry to the legend (the status was used by the existing universal-links row but never defined). The0 user-facing gaps/0 user-facing swap blockersfigures are unchanged and remain correct.3. Corrected the macOS XCUITest counts. The audit claimed "13 new MacOS test classes, 1492 lines".
Tests/PackRatMacUITests/actually holds 7 files; PR #2627 retires 5 of them for aPackRatMacOSUITestsbundle that currently contains onlyInfo.plist. Also clarifies thatPackRatUITests/UITestFeatureFlags.swiftis test infrastructure, not flag coverage.Plus a dated amendment header recording two things the file didn't say: it is stale (335 commits to
apps/expovs 107 toapps/swiftsince 2026-05-20), andparityhere is a capability-level claim, so behavioral defects inside a delivered capability — e.g. the four tester bugs fixed in #2627 — have no cell to appear in.Validation
findonapps/expo/features/purchases/,grep -ril 'StoreKit|RevenueCat|Purchases|paywall|subscription'acrossapps/swift/Sources(one hit, the generated flag),grep -rn enableRevenueCatfor consumers (none outside the generated file and its UI-test mirror),lson both macOS test bundles, andgit log --since=2026-05-20for the churn counts.Notes
*View.swift), which is the granularity at which the 🧪 Harden Swift beta tester readiness #2627 class of tester bug becomes visible.Summary by CodeRabbit