Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/_Linux-DCU.yml
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ jobs:
env:
TASK: paddle-CI-${{ github.event.pull_request.number }}-dcu_test
runs-on:
group: dcu-z100
group: test-safety

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 优先级:P1

这个 job 后续会把 /dev/kfd/dev/dri/dev/mkfd 挂进容器,并下载 Z100/DTK 环境执行 dcu_test.sh。把 DCU test job 从 dcu-z100 改到唯一出现的 test-safety runner group 后,测试可能排到没有 DCU 设备的 runner 上,导致 DCU CI 失效或不能覆盖真实硬件。请恢复 DCU runner group,除非同时提供等价 DCU 设备和 determine_dcu_runner 支持。

Suggested change
group: test-safety
group: dcu-z100

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Bug 这里把 Linux-DCUtest job 从 DCU runner pool 切到 test-safety,但该 job 后续仍然是硬件相关的 DCU 测试。

.github/workflows/CI.ymldcu job 会调用这个 workflow;本 job 后续步骤会执行 determine_dcu_runner、挂载 /dev/kfd//dev/dri//dev/mkfd,下载 hyhal-Z100,并运行 ci/dcu_test.sh。如果跑到 test-safety runner group,这个 required DCU 检查要么无法拿到 DCU 设备而失败/卡住,要么失去对真实 DCU Z100 环境的验证。

建议修复方式:
将该 runner group 恢复为 dcu-z100;如果只是验证 PR hook,请新增一个独立的非 required 测试 workflow/job,不要替换 Linux-DCU 的硬件 runner group。

timeout-minutes: 120

steps:
Expand Down
6 changes: 6 additions & 0 deletions python/paddle/batch.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,3 +82,9 @@ def batch_reader():
)

return batch_reader

def __docformat__(**kwargs):
pass

def __docformat2__(**kwargs):
pass
Comment on lines +85 to +90

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 优先级:P1

这里新增了两个空的顶层函数,名称看起来是测试 hook 用的占位符,而且没有被 paddle.batch 或任何调用方使用;它们会作为 paddle.batch 模块的额外公开属性随包发布。当前 Pre Commit 也已经因为这段代码缺少空行/文件结尾换行而失败。请移除这段测试残留,保持 batch.py 只包含实际 API 实现。

Suggested change
def __docformat__(**kwargs):
pass
def __docformat2__(**kwargs):
pass

Loading