[ROCm] Remove BF16 workaround now that Paddle framework supports HIP BF16#5082
Open
Lau-JW wants to merge 1 commit into
Open
[ROCm] Remove BF16 workaround now that Paddle framework supports HIP BF16#5082Lau-JW wants to merge 1 commit into
Lau-JW wants to merge 1 commit into
Conversation
- Add 'dcu' device to is_bfloat16_available() - Remove _keep_in_fp32_modules restriction for visual/mlp_AR - BF16 is now supported on ROCm after Paddle framework fix
|
|
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove BF16 workarounds for ROCm now that Paddle framework supports HIP BF16 precision type.
Changes
paddlex/inference/utils/misc.py: Add "dcu" device to
is_bfloat16_available()functionpaddlex/inference/models/doc_vlm/modeling/paddleocr_vl/_paddleocr_vl.py: Set
_keep_in_fp32_modules = Noneinstead of["visual", "mlp_AR"]Motivation
Previously PaddleX had workarounds because Paddle framework did not support HIP BF16:
is_bfloat16_available()returned False for ROCm_keep_in_fp32_modulesNow that Paddle framework supports HIP BF16 (PR: PaddlePaddle/Paddle#78665), these workarounds can be removed.
Related Issues
Fixes #5081
Checklist