fix: 3 security fixes#1
Open
androw wants to merge 3 commits into
Open
Conversation
User-controlled values (sessionId, user.id) were stored in systemEvents and rendered via innerHTML without escaping, allowing stored XSS payloads to execute in the admin's browser. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
createMarkerElement injected user-supplied name and distance directly into innerHTML, allowing any session member to execute scripts in every other participant's browser via a crafted display name. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When HEALTH_PASSWORD was unset, undefined === undefined caused the auth middleware to grant unauthenticated access to the health dashboard and all session data it exposes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full disclosure: IA authored