backport: assumeutxo M2 — EvoDB multi-chainstate isolation and subsystem gating

.github/workflows/build-depends.yml

@@ -57,9 +57,7 @@ jobs:
           sparse-checkout: |
             ci/dash
             ci/test
-            depends/Makefile
-            depends/packages
-            depends/hosts
+            depends
             contrib/containers/ci/ci.Dockerfile
             contrib/containers/ci/ci-slim.Dockerfile
             contrib/containers/guix/scripts/setup-sdk
@@ -75,9 +73,9 @@ jobs:
           DEP_HASH="$(echo -n "${BUILD_TARGET}" "${DEP_OPTS}" "${HOST}" | sha256sum | head -c 64)"
           echo "DEP_HASH=${DEP_HASH}" >> "${GITHUB_OUTPUT}"
           DOCKERFILE_HASH="${{ hashFiles('contrib/containers/ci/ci.Dockerfile', 'contrib/containers/ci/ci-slim.Dockerfile') }}"
-          PACKAGES_HASH="${{ hashFiles('depends/packages/*', 'depends/Makefile') }}"
+          DEPENDS_INPUTS_HASH="${{ hashFiles('depends/Makefile', 'depends/funcs.mk', 'depends/gen_id', 'depends/config.guess', 'depends/config.sub', 'depends/config.site.in', 'depends/builders/**', 'depends/hosts/**', 'depends/packages/**', 'depends/patches/**') }}"
           CACHE_KEY_PREFIX="depends-${DOCKERFILE_HASH}-${{ inputs.base-image-digest }}-${{ inputs.runs-on }}-${{ inputs.build-target }}"
-          CACHE_KEY="${CACHE_KEY_PREFIX}-${DEP_HASH}-${PACKAGES_HASH}"
+          CACHE_KEY="${CACHE_KEY_PREFIX}-${DEP_HASH}-${DEPENDS_INPUTS_HASH}"
           echo "cache-key-prefix=${CACHE_KEY_PREFIX}" >> "${GITHUB_OUTPUT}"
           echo "cache-key=${CACHE_KEY}" >> "${GITHUB_OUTPUT}"
           echo "Cache key: ${CACHE_KEY}"

AGENTS.md

@@ -98,7 +98,12 @@ CI/lint list changes.
 ## Test Commands
 
 Choose tests based on the files touched. Do not claim broad validation if only a
-targeted test was run.
+targeted test was run. Prefer adding test cases to existing files over creating a
+new unit or functional test file. Only create a new test file when the additions
+would make an existing file overly complicated, when a separate file yields
+clearly improved performance (e.g. parallel execution or isolation), or when the
+subject being tested is distinctly separate and does not logically belong in an
+existing file. Fewer files reduce test setup overhead and compilation time.
 
 ```bash
 # All unit tests
@@ -176,16 +181,12 @@ For these areas, prefer small tests that prove the invariant being changed.
 
 ## PR Hygiene
 
+- When creating pull requests, follow `.github/PULL_REQUEST_TEMPLATE.md` for the description and ensure the PR title satisfies the active linter in `.github/workflows/semantic-pull-request.yml` (using Conventional Commits, including `backport:` for Bitcoin Core backports).
 - Use atomic commits. Each commit should make sense on its own and generally
   build and pass tests. An intentionally non-building commit (e.g. a
   regression test landing before its fix) is fine if called out explicitly so
   it isn't mistaken for an oversight.
-- PR titles follow Conventional Commits, including `backport:` for Bitcoin Core
-  backports. Valid types/scopes are enforced by CI; see
-  `.github/workflows/semantic-pull-request.yml`.
-- PR descriptions must follow `.github/PULL_REQUEST_TEMPLATE.md`: remove the
-  italicized helper prompts, fill in the required sections, and keep the
-  checklist accurate for the change.
+- Remove the italicized helper prompts from `.github/PULL_REQUEST_TEMPLATE.md`, fill in the required sections, and keep the checklist accurate for the change.
 - Do not put `@` mentions in PR descriptions; they are copied into merge
   commits and notify users repeatedly.
 - Explain what changed and why. For bug fixes, include the failure mode and why

CLAUDE.md

@@ -98,7 +98,12 @@ CI/lint list changes.
 ## Test Commands
 
 Choose tests based on the files touched. Do not claim broad validation if only a
-targeted test was run.
+targeted test was run. Prefer adding test cases to existing files over creating a
+new unit or functional test file. Only create a new test file when the additions
+would make an existing file overly complicated, when a separate file yields
+clearly improved performance (e.g. parallel execution or isolation), or when the
+subject being tested is distinctly separate and does not logically belong in an
+existing file. Fewer files reduce test setup overhead and compilation time.
 
 ```bash
 # All unit tests
@@ -176,16 +181,12 @@ For these areas, prefer small tests that prove the invariant being changed.
 
 ## PR Hygiene
 
+- When creating pull requests, follow `.github/PULL_REQUEST_TEMPLATE.md` for the description and ensure the PR title satisfies the active linter in `.github/workflows/semantic-pull-request.yml` (using Conventional Commits, including `backport:` for Bitcoin Core backports).
 - Use atomic commits. Each commit should make sense on its own and generally
   build and pass tests. An intentionally non-building commit (e.g. a
   regression test landing before its fix) is fine if called out explicitly so
   it isn't mistaken for an oversight.
-- PR titles follow Conventional Commits, including `backport:` for Bitcoin Core
-  backports. Valid types/scopes are enforced by CI; see
-  `.github/workflows/semantic-pull-request.yml`.
-- PR descriptions must follow `.github/PULL_REQUEST_TEMPLATE.md`: remove the
-  italicized helper prompts, fill in the required sections, and keep the
-  checklist accurate for the change.
+- Remove the italicized helper prompts from `.github/PULL_REQUEST_TEMPLATE.md`, fill in the required sections, and keep the checklist accurate for the change.
 - Do not put `@` mentions in PR descriptions; they are copied into merge
   commits and notify users repeatedly.
 - Explain what changed and why. For bug fixes, include the failure mode and why

ci/test/00_setup_env_native_tsan.sh

@@ -30,6 +30,6 @@ export DEP_OPTS="CC=clang-19 CXX='clang++-19 -stdlib=libc++'"
 export TEST_RUNNER_EXTRA="--extended --exclude feature_pruning,feature_dbcrash,wallet_multiwallet.py" # Temporarily suppress ASan heap-use-after-free (see issue #14163)
 export TEST_RUNNER_EXTRA="${TEST_RUNNER_EXTRA} --timeout-factor=4"  # Increase timeout because sanitizers slow down
 export GOAL="install"
-export BITCOIN_CONFIG="--enable-zmq --with-sanitizers=thread CC=clang-19 CXX=clang++-19 CXXFLAGS='-g'"
+export BITCOIN_CONFIG="--enable-zmq --with-sanitizers=thread CC=clang-19 CXX=clang++-19"
 export CPPFLAGS="-DARENA_DEBUG -DDEBUG_LOCKORDER -DDEBUG_LOCKCONTENTION"
 export PYZMQ=true

configure.ac

@@ -2,7 +2,7 @@ AC_PREREQ([2.69])
 dnl Don't forget to push a corresponding tag when updating any of _CLIENT_VERSION_* numbers
 define(_CLIENT_VERSION_MAJOR, 23)
 define(_CLIENT_VERSION_MINOR, 1)
-define(_CLIENT_VERSION_BUILD, 7)
+define(_CLIENT_VERSION_BUILD, 8)
 define(_CLIENT_VERSION_IS_RELEASE, false)
 define(_COPYRIGHT_YEAR, 2026)
 define(_COPYRIGHT_HOLDERS,[The %s developers])
@@ -1228,16 +1228,10 @@ if test "$enable_stacktraces" != "no"; then
       ])
     fi
     BACKTRACE_LIBS="$BACKTRACE_LIBS -lbacktrace"
-    dnl More modern compilers may emit DWARF 5 binaries by default, use DWARF 4 out of precaution
-    if test "$TARGET_OS" != "windows"; then
-      AX_CHECK_COMPILE_FLAG([-gdwarf-4], [BACKTRACE_FLAGS="$BACKTRACE_FLAGS -gdwarf-4"], [
-        if test "$enable_stacktraces" = "yes"; then
-          AC_MSG_ERROR([--enable-stacktraces was specified but cannot set -gdwarf-4])
-        fi
-        AC_MSG_WARN([cannot set -gdwarf-4, stacktraces will be disabled])
-        enable_stacktraces=no
-      ], [$CXXFLAG_WERROR])
-    fi
+    dnl The libbacktrace pinned in depends understands DWARF 5, so the
+    dnl compiler's default debug format is used as-is. A -gdwarf-4 pin
+    dnl previously lived here and, being a -g-family flag, also forced
+    dnl debug level 2 onto every build.
     if test "$TARGET_OS" = "darwin"; then
       AX_CHECK_COMPILE_FLAG([-fno-standalone-debug], [BACKTRACE_FLAGS="$BACKTRACE_FLAGS -fno-standalone-debug"], [
         if test "$enable_stacktraces" = "yes"; then
@@ -2139,10 +2133,10 @@ echo "  target os       = $host_os"
 echo "  build os        = $build_os"
 echo
 echo "  CC              = $CC"
-echo "  CFLAGS          = $DEBUG_CFLAGS $PTHREAD_CFLAGS $BACKTRACE_FLAGS $CFLAGS"
+echo "  CFLAGS          = $BACKTRACE_FLAGS $DEBUG_CFLAGS $PTHREAD_CFLAGS $CFLAGS"
 echo "  CPPFLAGS        = $DEBUG_CPPFLAGS $HARDENED_CPPFLAGS $CORE_CPPFLAGS $CPPFLAGS"
 echo "  CXX             = $CXX"
-echo "  CXXFLAGS        = $DEBUG_CXXFLAGS $HARDENED_CXXFLAGS $WARN_CXXFLAGS $NOWARN_CXXFLAGS $ERROR_CXXFLAGS $CORE_CXXFLAGS $BACKTRACE_FLAGS $CXXFLAGS"
+echo "  CXXFLAGS        = $BACKTRACE_FLAGS $DEBUG_CXXFLAGS $HARDENED_CXXFLAGS $WARN_CXXFLAGS $NOWARN_CXXFLAGS $ERROR_CXXFLAGS $CORE_CXXFLAGS $CXXFLAGS"
 echo "  LDFLAGS         = $PTHREAD_LIBS $HARDENED_LDFLAGS $CORE_LDFLAGS $BACKTRACE_LDFLAGS $LDFLAGS"
 echo "  AR              = $AR"
 echo "  ARFLAGS         = $ARFLAGS"

contrib/flatpak/org.dash.dash-core.metainfo.xml

@@ -21,6 +21,7 @@
     </screenshot>
   </screenshots>
   <releases>
+    <release date="2026-07-30" version="23.1.8"/>
     <release date="2026-06-30" version="23.1.7"/>
     <release date="2026-06-19" version="23.1.5"/>
     <release date="2026-06-13" version="23.1.4"/>

contrib/guix/libexec/build.sh

@@ -222,7 +222,13 @@ HOST_CFLAGS+=$(find /gnu/store -maxdepth 1 -mindepth 1 -type d -exec echo -n " -
 case "$HOST" in
     *linux*)  HOST_CFLAGS+=" -ffile-prefix-map=${PWD}=." ;;
     *mingw*)  HOST_CFLAGS+=" -fno-ident" ;;
-    *darwin*) unset HOST_CFLAGS ;;
+    *darwin*)
+        # Optimization and target flags come from depends' config.site; only
+        # the debug level is requested here. The shipped dSYM debug artifacts
+        # previously carried full -g2 DWARF via the since-removed -gdwarf-4
+        # backtrace flag escalating configure's -g1 floor, so keep requesting
+        # it explicitly.
+        HOST_CFLAGS="-g" ;;
 esac
 
 # CXXFLAGS

depends/hosts/darwin.mk

@@ -57,15 +57,25 @@ darwin_STRIP=$(shell $(SHELL) $(.SHELLFLAGS) "command -v llvm-strip")
 #         in the SDK, where __has_feature(modules) is used to define USE_CLANG_TYPES,
 #         which is in turn used as an include guard.
 
-# TODO: remove C_INCLUDE_PATH when it is indeed useless
-# https://github.com/bitcoin/bitcoin/pull/30451 has been partiall reverted in #7184 and should be re-applied
-darwin_CC=env -u C_INCLUDE_PATH -u CPLUS_INCLUDE_PATH $(clang_prog) --target=$(host) \
+# TODO: remove C_INCLUDE_PATH/darwin_env_unset when bitcoin#30451 is fully backported.
+# C_INCLUDE_PATH/CPLUS_INCLUDE_PATH leak native-toolchain headers into the
+# darwin cross-build and conflict with the SDK headers. Guix exports them
+# (contrib/guix/libexec/build.sh), so strip them there with an `env -u`
+# prefix. The prefix must not be emitted when the variables aren't set:
+# ccache cannot parse a compiler command starting with `env` (it treats
+# `env` as the compiler and the absolute clang path as a second source
+# file), so an unconditional prefix silently disables ccache for every
+# darwin compile. Unlike upstream (bitcoin#30451, which dropped the prefix
+# entirely), our Guix environment still sets these variables.
+ifneq ($(origin C_INCLUDE_PATH) $(origin CPLUS_INCLUDE_PATH),undefined undefined)
+darwin_env_unset=env -u C_INCLUDE_PATH -u CPLUS_INCLUDE_PATH
+endif
+
+darwin_CC=$(darwin_env_unset) $(clang_prog) --target=$(host) \
               -isysroot$(OSX_SDK) -nostdlibinc \
               -iwithsysroot/usr/include -iframeworkwithsysroot/System/Library/Frameworks
 
-# TODO: remove C_INCLUDE_PATH when it is indeed useless
-# https://github.com/bitcoin/bitcoin/pull/30451 has been partiall reverted in #7184 and should be re-applied
-darwin_CXX=env -u C_INCLUDE_PATH -u CPLUS_INCLUDE_PATH $(clangxx_prog) --target=$(host) \
+darwin_CXX=$(darwin_env_unset) $(clangxx_prog) --target=$(host) \
                -isysroot$(OSX_SDK) -nostdlibinc \
                -iwithsysroot/usr/include/c++/v1 \
                -iwithsysroot/usr/include -iframeworkwithsysroot/System/Library/Frameworks

doc/man/dash-cli.1

@@ -1,7 +1,7 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
-.TH DASH-CLI "1" "June 2026" "dash-cli v23.1.7" "User Commands"
+.TH DASH-CLI "1" "July 2026" "dash-cli v23.1.8" "User Commands"
 .SH NAME
-dash-cli \- manual page for dash-cli v23.1.7
+dash-cli \- manual page for dash-cli v23.1.8
 .SH SYNOPSIS
 .B dash-cli
 [\fI\,options\/\fR] \fI\,<command> \/\fR[\fI\,params\/\fR]  \fI\,Send command to Dash Core\/\fR
@@ -15,7 +15,7 @@ dash-cli \- manual page for dash-cli v23.1.7
 .B dash-cli
 [\fI\,options\/\fR] \fI\,help <command>      Get help for a command\/\fR
 .SH DESCRIPTION
-Dash Core RPC client version v23.1.7
+Dash Core RPC client version v23.1.8
 .SH OPTIONS
 .HP
 \-?

doc/man/dash-qt.1

@@ -1,12 +1,12 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
-.TH DASH-QT "1" "June 2026" "dash-qt v23.1.7" "User Commands"
+.TH DASH-QT "1" "July 2026" "dash-qt v23.1.8" "User Commands"
 .SH NAME
-dash-qt \- manual page for dash-qt v23.1.7
+dash-qt \- manual page for dash-qt v23.1.8
 .SH SYNOPSIS
 .B dash-qt
 [\fI\,command-line options\/\fR] [\fI\,URI\/\fR]
 .SH DESCRIPTION
-Dash Core version v23.1.7
+Dash Core version v23.1.8
 .PP
 Optional URI is a Dash address in BIP21 URI format.
 .SH OPTIONS
@@ -128,13 +128,13 @@ Do not keep transactions in the mempool longer than <n> hours (default:
 .HP
 \fB\-par=\fR<n>
 .IP
-Set the number of script verification threads (0 = auto, <0 = leave that many
-cores free, max: 15, default: 0)
+Set the number of script verification threads (0 = auto, <0 = leave that
+many cores free, max: 15, default: 0)
 .HP
 \fB\-parbls=\fR<n>
 .IP
-Set the number of BLS verification threads (0 = auto, <0 = leave that many
-cores free, max: 33, default: 0)
+Set the number of BLS verification threads (0 = auto, <0 = leave that
+many cores free, max: 33, default: 0)
 .HP
 \fB\-persistmempool\fR
 .IP

doc/man/dash-tx.1

@@ -1,15 +1,15 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
-.TH DASH-TX "1" "June 2026" "dash-tx v23.1.7" "User Commands"
+.TH DASH-TX "1" "July 2026" "dash-tx v23.1.8" "User Commands"
 .SH NAME
-dash-tx \- manual page for dash-tx v23.1.7
+dash-tx \- manual page for dash-tx v23.1.8
 .SH SYNOPSIS
 .B dash-tx
 [\fI\,options\/\fR] \fI\,<hex-tx> \/\fR[\fI\,commands\/\fR]  \fI\,Update hex-encoded dash transaction\/\fR
 .br
 .B dash-tx
 [\fI\,options\/\fR] \fI\,-create \/\fR[\fI\,commands\/\fR]   \fI\,Create hex-encoded dash transaction\/\fR
 .SH DESCRIPTION
-Dash Core dash\-tx utility version v23.1.7
+Dash Core dash\-tx utility version v23.1.8
 .SH OPTIONS
 .HP
 \-?

doc/man/dash-util.1

@@ -1,12 +1,12 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
-.TH DASH-UTIL "1" "June 2026" "dash-util v23.1.7" "User Commands"
+.TH DASH-UTIL "1" "July 2026" "dash-util v23.1.8" "User Commands"
 .SH NAME
-dash-util \- manual page for dash-util v23.1.7
+dash-util \- manual page for dash-util v23.1.8
 .SH SYNOPSIS
 .B dash-util
 [\fI\,options\/\fR] [\fI\,commands\/\fR]  \fI\,Do stuff\/\fR
 .SH DESCRIPTION
-Dash Core dash\-util utility version v23.1.7
+Dash Core dash\-util utility version v23.1.8
 .SH OPTIONS
 .HP
 \-?

doc/man/dash-wallet.1

@@ -1,9 +1,9 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
-.TH DASH-WALLET "1" "June 2026" "dash-wallet v23.1.7" "User Commands"
+.TH DASH-WALLET "1" "July 2026" "dash-wallet v23.1.8" "User Commands"
 .SH NAME
-dash-wallet \- manual page for dash-wallet v23.1.7
+dash-wallet \- manual page for dash-wallet v23.1.8
 .SH DESCRIPTION
-Dash Core dash\-wallet version v23.1.7
+Dash Core dash\-wallet version v23.1.8
 .PP
 dash\-wallet is an offline tool for creating and interacting with Dash Core wallet files.
 By default dash\-wallet will act on wallets in the default mainnet wallet directory in the datadir.

doc/man/dashd.1

@@ -1,12 +1,12 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
-.TH DASHD "1" "June 2026" "dashd v23.1.7" "User Commands"
+.TH DASHD "1" "July 2026" "dashd v23.1.8" "User Commands"
 .SH NAME
-dashd \- manual page for dashd v23.1.7
+dashd \- manual page for dashd v23.1.8
 .SH SYNOPSIS
 .B dashd
 [\fI\,options\/\fR]                     \fI\,Start Dash Core\/\fR
 .SH DESCRIPTION
-Dash Core version v23.1.7
+Dash Core version v23.1.8
 .SH OPTIONS
 .HP
 \-?
@@ -126,13 +126,13 @@ Do not keep transactions in the mempool longer than <n> hours (default:
 .HP
 \fB\-par=\fR<n>
 .IP
-Set the number of script verification threads (0 = auto, <0 = leave that many
-cores free, max: 15, default: 0)
+Set the number of script verification threads (0 = auto, <0 = leave that
+many cores free, max: 15, default: 0)
 .HP
 \fB\-parbls=\fR<n>
 .IP
-Set the number of BLS verification threads (0 = auto, <0 = leave that many
-cores free, max: 33, default: 0)
+Set the number of BLS verification threads (0 = auto, <0 = leave that
+many cores free, max: 33, default: 0)
 .HP
 \fB\-persistmempool\fR
 .IP