Skip to content

PMM-14912-dynamic-thresholds (FB) - #4449

Draft
matejkubinec wants to merge 15 commits into
v3from
PMM-14912-dynamic-thresholds
Draft

PMM-14912-dynamic-thresholds (FB)#4449
matejkubinec wants to merge 15 commits into
v3from
PMM-14912-dynamic-thresholds

Conversation

@matejkubinec

@matejkubinec matejkubinec commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Custom branches:

This was referenced Jul 1, 2026
Closed
Draft
@JNKPercona

JNKPercona commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Looks like there are outdated source branches.
Please update them and restart the job
percona/grafana#912

@JNKPercona

JNKPercona commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Server docker: perconalab/pmm-server-fb:PR-4449-2d45cbd
Client docker: perconalab/pmm-client-fb:PR-4449-2d45cbd
Watchtower docker: perconalab/pmm-watchtower-fb:PR-4449-2d45cbd
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4449-2d45cbd.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-4449-2d45cbd&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4449-2d45cbd.tar.gz

@JNKPercona

JNKPercona commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/6665/

@JNKPercona

JNKPercona commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Server docker: perconalab/pmm-server-fb:PR-4449-819cb70
Client docker: perconalab/pmm-client-fb:PR-4449-819cb70
Watchtower docker: perconalab/pmm-watchtower-fb:PR-4449-819cb70
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4449-819cb70.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-4449-819cb70&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4449-819cb70.tar.gz

@JNKPercona

JNKPercona commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/6837/

@JNKPercona

JNKPercona commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Looks like there are outdated source branches.
Please update them and restart the job
percona/pmm#5579

@JNKPercona

JNKPercona commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Server docker: perconalab/pmm-server-fb:PR-4449-9fd35fe
Client docker: perconalab/pmm-client-fb:PR-4449-9fd35fe
Watchtower docker: perconalab/pmm-watchtower-fb:PR-4449-9fd35fe
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4449-9fd35fe.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-4449-9fd35fe&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4449-9fd35fe.tar.gz

@JNKPercona

JNKPercona commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/6869/

@JNKPercona

JNKPercona commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Server docker: perconalab/pmm-server-fb:PR-4449-a3b42b0
Client docker: perconalab/pmm-client-fb:PR-4449-a3b42b0
Watchtower docker: perconalab/pmm-watchtower-fb:PR-4449-a3b42b0
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4449-a3b42b0.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-4449-a3b42b0&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4449-a3b42b0.tar.gz

@JNKPercona

JNKPercona commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/6872/

@JNKPercona

JNKPercona commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Server docker: perconalab/pmm-server-fb:PR-4449-b669d75
Client docker: perconalab/pmm-client-fb:PR-4449-b669d75
Watchtower docker: perconalab/pmm-watchtower-fb:PR-4449-b669d75
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4449-b669d75.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-4449-b669d75&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4449-b669d75.tar.gz

@JNKPercona

JNKPercona commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/6875/

@JNKPercona

JNKPercona commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Server docker: perconalab/pmm-server-fb:PR-4449-f80b7c8
Client docker: perconalab/pmm-client-fb:PR-4449-f80b7c8
Watchtower docker: perconalab/pmm-watchtower-fb:PR-4449-f80b7c8
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4449-f80b7c8.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-4449-f80b7c8&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4449-f80b7c8.tar.gz

@JNKPercona

JNKPercona commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/6876/

@JNKPercona

JNKPercona commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Server docker: perconalab/pmm-server-fb:PR-4449-3256b5e
Client docker: perconalab/pmm-client-fb:PR-4449-3256b5e
Watchtower docker: perconalab/pmm-watchtower-fb:PR-4449-3256b5e
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4449-3256b5e.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-4449-3256b5e&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4449-3256b5e.tar.gz

@JNKPercona

JNKPercona commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/6894/

@JNKPercona

JNKPercona commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Looks like there are outdated source branches.
Please update them and restart the job
percona/pmm#5579
percona/grafana#912

@matejkubinec matejkubinec mentioned this pull request Sep 2, 2026
Draft
@JNKPercona

JNKPercona commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Server docker: perconalab/pmm-server-fb:PR-4449-3eded28
Client docker: perconalab/pmm-client-fb:PR-4449-3eded28
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4449-3eded28.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-4449-3eded28&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4449-3eded28.tar.gz

@JNKPercona

JNKPercona commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/7222/

@travagliad Claude

travagliad commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

The red @fb-alerting|@fb-settings UI tests check on this PR reproduced, and it is a pmm-qa test bug, not a problem with your change — nothing here needs fixing on your side. All 13 actionable failures are in codeceptjs-e2e/tests/ia/ruleTemplates_test.js and share one cause: the rule-template row-action locators address a template via //td[contains(text(), "NAME")], and the new Name-column Cell renderer in percona/grafana#912 moves the name into <td><div><span>NAME</span></div></td> — XPath text() only sees a node's direct text children, so every lookup by name matches nothing.

Verified on a throwaway VM running this PR's own build perconalab/pmm-server-fb:PR-4449-3eded28: against the live table the current locator returns 0 matches and a row-scoped contains(.) one returns 1, and the suite goes from 13 passed, 13 failed to 26 passed, 0 failed with only the locators changed.

Fix: percona/pmm-qa#1297. It matches both DOM shapes (re-verified green on perconalab/pmm-server:3-dev-latest too), so it is not blocked on grafana#912 and needs no coordination with your merge. Once it lands, this check should go green on your next FB build.

Generated by Claude Code

@JNKPercona

JNKPercona commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Looks like there are outdated source branches.
Please update them and restart the job
percona/grafana#912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matejkubinec @JNKPercona @travagliad