PMM-14109-improve-advisor-ux

[ademidoff]

https://jira.percona.com/browse/PMM-14109

• PMM-14109 Improve Advisor UX percona/pmm#5656
• PMM-14109 New Advisor UX percona/grafana#913
• PMM-14109 Improve Advisor UX percona/pmm-qa#1083

[JNKPercona]

Server docker: perconalab/pmm-server-fb:PR-4478-8367885
Client docker: perconalab/pmm-client-fb:PR-4478-8367885
Watchtower docker: perconalab/pmm-watchtower-fb:PR-4478-8367885
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-8367885.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-4478-8367885&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-8367885.tar.gz

[JNKPercona]

API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/6767/

[JNKPercona]

Server docker: perconalab/pmm-server-fb:PR-4478-e9234a6
Client docker: perconalab/pmm-client-fb:PR-4478-e9234a6
Watchtower docker: perconalab/pmm-watchtower-fb:PR-4478-e9234a6
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-e9234a6.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-4478-e9234a6&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-e9234a6.tar.gz

[JNKPercona]

API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/6775/

[JNKPercona]

Server docker: perconalab/pmm-server-fb:PR-4478-ae8505d
Client docker: perconalab/pmm-client-fb:PR-4478-ae8505d
Watchtower docker: perconalab/pmm-watchtower-fb:PR-4478-ae8505d
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-ae8505d.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-4478-ae8505d&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-ae8505d.tar.gz

[JNKPercona]

API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/6790/

[JNKPercona]

Server docker: perconalab/pmm-server-fb:PR-4478-af97f42
Client docker: perconalab/pmm-client-fb:PR-4478-af97f42
Watchtower docker: perconalab/pmm-watchtower-fb:PR-4478-af97f42
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-af97f42.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-4478-af97f42&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-af97f42.tar.gz

[JNKPercona]

API tests have failed: https://pmm.cd.percona.com/job/pmm3-api-tests/6858/

[JNKPercona]

Server docker: perconalab/pmm-server-fb:PR-4478-0862c5f
Client docker: perconalab/pmm-client-fb:PR-4478-0862c5f
Watchtower docker: perconalab/pmm-watchtower-fb:PR-4478-0862c5f
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-0862c5f.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-4478-0862c5f&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-0862c5f.tar.gz

[JNKPercona]

API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/6860/

[JNKPercona]

Server docker: perconalab/pmm-server-fb:PR-4478-fc7aa9a
Client docker: perconalab/pmm-client-fb:PR-4478-fc7aa9a
Watchtower docker: perconalab/pmm-watchtower-fb:PR-4478-fc7aa9a
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-fc7aa9a.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-4478-fc7aa9a&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-fc7aa9a.tar.gz

[JNKPercona]

API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/6861/

[JNKPercona]

Server docker: perconalab/pmm-server-fb:PR-4478-2ea9af2
Client docker: perconalab/pmm-client-fb:PR-4478-2ea9af2
Watchtower docker: perconalab/pmm-watchtower-fb:PR-4478-2ea9af2
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-2ea9af2.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-4478-2ea9af2&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-2ea9af2.tar.gz

[JNKPercona]

API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/6863/

[JNKPercona]

Server docker: perconalab/pmm-server-fb:PR-4478-11e08c5
Client docker: perconalab/pmm-client-fb:PR-4478-11e08c5
Watchtower docker: perconalab/pmm-watchtower-fb:PR-4478-11e08c5
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-11e08c5.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-4478-11e08c5&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-11e08c5.tar.gz

[JNKPercona]

API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/6883/

[JNKPercona]

Server docker: perconalab/pmm-server-fb:PR-4478-7aa874d
Client docker: perconalab/pmm-client-fb:PR-4478-7aa874d
Watchtower docker: perconalab/pmm-watchtower-fb:PR-4478-7aa874d
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-7aa874d.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-4478-7aa874d&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-7aa874d.tar.gz

[JNKPercona]

API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/6905/

[JNKPercona]

Server docker: perconalab/pmm-server-fb:PR-4478-b518f25
Client docker: perconalab/pmm-client-fb:PR-4478-b518f25
Watchtower docker: perconalab/pmm-watchtower-fb:PR-4478-b518f25
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-b518f25.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-4478-b518f25&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-b518f25.tar.gz

[JNKPercona]

API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/6936/

[JNKPercona]

Server docker: perconalab/pmm-server-fb:PR-4478-808d098
Client docker: perconalab/pmm-client-fb:PR-4478-808d098
Watchtower docker: perconalab/pmm-watchtower-fb:PR-4478-808d098
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-808d098.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-4478-808d098&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-808d098.tar.gz

[JNKPercona]

API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/7065/

[JNKPercona]

Server docker: perconalab/pmm-server-fb:PR-4478-16ec9e4
Client docker: perconalab/pmm-client-fb:PR-4478-16ec9e4
Watchtower docker: perconalab/pmm-watchtower-fb:PR-4478-16ec9e4
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-16ec9e4.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-4478-16ec9e4&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-16ec9e4.tar.gz

[JNKPercona]

API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/7071/

[JNKPercona]

Server docker: perconalab/pmm-server-fb:PR-4478-1cb361d
Client docker: perconalab/pmm-client-fb:PR-4478-1cb361d
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-1cb361d.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-4478-1cb361d&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-1cb361d.tar.gz

[JNKPercona]

API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/7172/

[travagliad]

The red @fb-alerting|@fb-settings check reproduced — it's a pmm-qa test issue in the PMM-14109 companion branch, not a problem with the server change. getSubpageTooltips() in pmmSettingsPage.js still lists the Advisors tooltip under /settings/advanced-settings, but percona/pmm#5656 moves AdvisorsForm to the dedicated /settings/advisors tab, so PMM-T1227 waits for [data-testid=advisors-label-description] on a page that no longer renders it.

Fix: percona/pmm-qa#1258, opened against PMM-14109-improve-advisor-ux (not main, where the current mapping is still correct). Verified on a throwaway VM with your FB image perconalab/pmm-server-fb:PR-4478-1cb361d: failing before, 1 passed after, and the spec's other @fb-settings scenarios stay green.

Merge that into your pmm-qa branch and the next FB run should be clean.

---

Generated by Claude Code

[JNKPercona]

Looks like there are outdated source branches.
Please update them and restart the job
percona/pmm#5656

[JNKPercona]

Server docker: perconalab/pmm-server-fb:PR-4478-b42a044
Client docker: perconalab/pmm-client-fb:PR-4478-b42a044
Client tarball: https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-b42a044.tar.gz
Staging instance: https://pmm.cd.percona.com/job/pmm3-aws-staging-start/parambuild/?DOCKER_VERSION=perconalab/pmm-server-fb:PR-4478-b42a044&CLIENT_VERSION=https://s3.us-east-2.amazonaws.com/pmm-build-cache/PR-BUILDS/pmm-client/pmm-client-PR-4478-b42a044.tar.gz

[JNKPercona]

API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/7185/

[travagliad]

Your red FB Tests run (33154828980) was looked at — the single failing check, @service-account / PMM-T1883, is a pmm-qa test bug and not your change. I reproduced it on a throwaway VM at your exact FB build (3.10.0-PMM-14109-improve-advisor-ux-b42a0448d): the test opens MySQL Instances Overview over from=now-1m right after starting its write load, but the URL carries no refresh param and that dashboard ships with refresh disabled, so Grafana queries the panels once — over a window that predates the load — and the 300s waitForGraphsToHaveData then just re-counts a frozen render. While the unfixed test sat there showing empty panels, the panel's own query returned 0.41 and the InnoDB counters were advancing in 25 of 30 consecutive 5s scrapes; the data was there, nothing was re-reading it. The metrics themselves are fine, so there's no product bug here.

Fix: percona/pmm-qa#1271 (adds refresh=10s; 3/3 first-attempt passes vs a first-attempt failure before). Note your FB run pins PMM_QA_BRANCH=PMM-14109-improve-advisor-ux, so it'll pick the fix up once that pmm-qa branch (#1083) is rebased on main after #1271 lands. Since it's a race rather than a hard failure, a re-run of the failed job may also come back green in the meantime.

---

Generated by Claude Code