PMM-15398 Build dashboards memory fix - #4550
Draft
theTibi wants to merge 1 commit into
Draft
Conversation
Feature build for percona/pmm#5855 - node Used memory now counts Shmem and SReclaimable instead of hiding shared_buffers in Cache. Signed-off-by: theTibi <tkorocz@gmail.com>
8 tasks
Collaborator
|
Server docker: perconalab/pmm-server-fb:PR-4550-77f19d7 |
Collaborator
|
API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/7192/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature build for PMM-15398 — node
Usedmemory now counts PostgreSQLshared_buffers.UsedwasMemTotal - (MemFree + Buffers + Cached), and/proc/meminfo:CachedincludesShmem, soshared_bufferswas subtracted out ofUsedand re-drawn asCache. This build carries the corrected expressions so QA can check the OS dashboards againstfreeon a real PostgreSQL node.Component PRs
ci.yml
What to look at
Open OS → Node Summary → Memory Utilization for a PostgreSQL node with a large
shared_buffersand compareUsedagainstfree -mon that host. Also check Memory Details → Memory Usage, Nodes Compare, and Nodes Overview → Top 5 Used Memory.Two things worth checking explicitly:
MemTotal—Used + Free + Buffers + Cache.rds_exporterdoes not exportSReclaimableorShmem, and the expressions carry a zero-fallback for exactly that case.Usedreads higher than before on every node — that is the fix, not a regression.Ticket