Skip to content

fix(train): guard checkpoint dir ops with rank 0 to prevent DDP race condition #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wadeKeith wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(train): guard checkpoint dir ops with rank 0 to prevent DDP race condition #908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions scripts/train_pytorch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,15 +329,23 @@ def train_loop(config: _config.TrainConfig):
else:
raise FileNotFoundError(f"Experiment checkpoint directory {exp_checkpoint_dir} does not exist for resume")
elif config.overwrite and config.checkpoint_dir.exists():
shutil.rmtree(config.checkpoint_dir)
logging.info(f"Overwriting checkpoint directory: {config.checkpoint_dir}")
# Only rank 0 should delete to avoid race conditions in DDP (see #868).
if is_main:
shutil.rmtree(config.checkpoint_dir)
logging.info(f"Overwriting checkpoint directory: {config.checkpoint_dir}")
if use_ddp:
dist.barrier()

# Create checkpoint directory with experiment name
if not resuming:
# For new runs, create experiment-specific checkpoint directory
# Only rank 0 creates the directory; other ranks wait behind the barrier.
if is_main:
exp_checkpoint_dir = config.checkpoint_dir
exp_checkpoint_dir.mkdir(parents=True, exist_ok=True)
logging.info(f"Created experiment checkpoint directory: {exp_checkpoint_dir}")
if use_ddp:
dist.barrier()
exp_checkpoint_dir = config.checkpoint_dir
exp_checkpoint_dir.mkdir(parents=True, exist_ok=True)
logging.info(f"Created experiment checkpoint directory: {exp_checkpoint_dir}")
else:
# For resume, checkpoint_dir is already set to the experiment directory
logging.info(f"Using existing experiment checkpoint directory: {config.checkpoint_dir}")
Expand Down