Remove pytest from runtime model import#923
Merged
jimmyt857 merged 1 commit intoPhysical-Intelligence:mainfrom Apr 15, 2026
Merged
Remove pytest from runtime model import#923jimmyt857 merged 1 commit intoPhysical-Intelligence:mainfrom
jimmyt857 merged 1 commit intoPhysical-Intelligence:mainfrom
Conversation
jimmyt857
approved these changes
Apr 15, 2026
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This removes an unintended runtime dependency on
pytestfromopenpi.models_pytorch.gemma_pytorch.The only usage was in a type annotation for
past_key_values:list[torch.FloatTensor] | pytest.Cache | Nonelist[torch.FloatTensor] | NoneWhy
pytestshould not be required to import or serve runtime model code.This showed up when using
openpiin a production inference image that excludes dev dependencies.In our serving environment,
openpi.models_pytorch.gemma_pytorchwas imported during model load, which caused the server to fail ifpytestwas not installed. Thepytestreference was only used in a type annotation and was not part of runtime behavior.Changes
import pytestfromsrc/openpi/models_pytorch/gemma_pytorch.pypytest.Cacheannotation onpast_key_valueswith a runtime-safe annotationValidation
pytestin this module was the type annotationNotes
I kept this patch intentionally narrow to avoid changing model behavior or cache semantics beyond removing the accidental test-only dependency.