-
Notifications
You must be signed in to change notification settings - Fork 101
fix(cors): reject wildcard origin with credentials #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Junman140
merged 2 commits into
Pi-Defi-world:dev
from
nice-bills:fix/cors-wildcard-with-credentials-315
May 29, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| /** Default browser origin for local development when CORS_ORIGIN is unset. */ | ||
| export const DEFAULT_DEV_CORS_ORIGIN = "http://localhost:3000"; | ||
|
|
||
| /** | ||
| * Parse and validate CORS_ORIGIN for credentialed cross-origin requests. | ||
| * Wildcard (*) is rejected: browsers forbid ACAO:* with Allow-Credentials. | ||
| */ | ||
| export function parseCorsOrigins(raw: string | undefined, nodeEnv: string): string[] { | ||
| const normalizedEnv = nodeEnv.trim().toLowerCase(); | ||
| const trimmed = raw?.trim(); | ||
|
|
||
| if (!trimmed) { | ||
| if (normalizedEnv === "production") { | ||
| throw new Error( | ||
| "CORS_ORIGIN is required in production. Set a comma-separated list of exact origins " + | ||
| "(e.g. https://app.example.com). Wildcard * is not allowed with credentials.", | ||
| ); | ||
| } | ||
| return [DEFAULT_DEV_CORS_ORIGIN]; | ||
| } | ||
|
|
||
| const origins = trimmed | ||
| .split(",") | ||
| .map((entry) => entry.trim()) | ||
| .filter(Boolean); | ||
|
|
||
| if (origins.length === 0) { | ||
| throw new Error( | ||
| "CORS_ORIGIN must list at least one origin when set (wildcard * is not allowed).", | ||
| ); | ||
| } | ||
|
|
||
| if (origins.some((origin) => origin === "*")) { | ||
| throw new Error( | ||
| "CORS_ORIGIN must not contain wildcard (*). List explicit origins; " + | ||
| "credentialed responses require Access-Control-Allow-Origin to match the request origin.", | ||
| ); | ||
| } | ||
|
|
||
| const normalized: string[] = []; | ||
| for (const origin of origins) { | ||
| let url: URL; | ||
| try { | ||
| url = new URL(origin); | ||
| } catch { | ||
| throw new Error( | ||
| `Invalid CORS origin "${origin}". Use full origins such as https://app.example.com`, | ||
| ); | ||
| } | ||
| if (url.protocol !== "http:" && url.protocol !== "https:") { | ||
| throw new Error( | ||
| `Invalid CORS origin "${origin}". Only http:// and https:// origins are supported.`, | ||
| ); | ||
| } | ||
| if (url.username || url.password || url.search || url.hash) { | ||
| throw new Error( | ||
| `Invalid CORS origin "${origin}". Provide scheme, host, and port only (no credentials in URL).`, | ||
| ); | ||
| } | ||
| if (url.pathname !== "/" || origin.endsWith("/")) { | ||
| throw new Error( | ||
| `Invalid CORS origin "${origin}". Provide scheme, host, and port only (no path or trailing slash).`, | ||
| ); | ||
| } | ||
| normalized.push(url.origin); | ||
| } | ||
|
|
||
| return [...new Set(normalized)]; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.