A implementation of Status Effects

[Crepestrom]

Related: #624

Related to pr: #3557
this is here to gather ideas on changes to it

Current Plan:

Status effects have 4 parts to their Zon
Type - (what type of status effect)
DecayStyle - (how stacks are removed when Timeleft reaches 0 eg; (-1 every removal or /2 every removal)) [not implimented yet]
OnUpdate - (A callback that applies some effect) [currently only for hurting player] [also need a more generalizable callback system]
BaseRefreshTime - (how long it takes for the status to decay)

When Applied they also have these 2 parts:
Stacks - (how many stacks of effects are applied)
Timeleft - (how much time until a stack is decayed) [not implimented yet]

Something Applying a status effect will have to provide these things:
Type - (what type of status effect)
Stacks - (how many at once)
Stacklimit - (the max limit that this source will give)
Merge type - (the way that this will add onto more of the same type of status effect) [not implimented yet]
DurationMult - (how much longer the duration lasts) (always overwritten by other providers) [not implimented yet]

Merge types come in different varieties:
Overwrite - (resets TimeLeft and sets the stack count directly)
OverwriteWeaker - (resets TimeLeft and sets the stack count directly, if the stacks of the overwritten status are lower than the overwriting one)
Add - (resets TimeLeft and adds onto the stacks)
AddNoRefresh - (does NOT resets TimeLeft and adds onto the stacks)

[Crepestrom]

Im trying to decide if its better to have how quickly a debuff lasts be applied by the Status Effect Provider or the Status Effect Zon
With a Provider

• It allows effects that extend the duration of debuffs or buffs
  With it Being Decided by the Zon
• It all means that different providers can't conflict with how long the debuff should last

[Crepestrom]

I suppose you could have a base durattion applied by the status zon
with providers applying a duration multiplier

[Crepestrom]

I am also wondering if anyone can help me figure out how to make 50 different callbacks with the same Parameters that can be called at different times
it would be used for different things
One that tracks how far a player has moved
One that updates every time a player has moved
One that changes how much mining damage a player does

[Crepestrom]

and how do we deal with the complicated durations when a stack is decreased and the duration goes down

[ZigguratV]

Some effects could have the stacks be a proxy for duration too. So they would gradually (-1/time) or quickly (/2) decrease in stacks.
Boolean effects simple (water breathing for example) and the stacks could be seconds remaining.

[ZigguratV]

I'm a bit confused about what's the difference between Timeleft and BaseRefreshTime

[ZigguratV]

Oh is BaseRefreshTime the starting duration and Timeleft what the timer has left, so together those are simply a timer