Item Frames - #3584
Conversation
Crepestrom
commented
Sep 8, 2026
Crepestrom
commented
Wunka
left a comment
Wunka
left a comment
There was a problem hiding this comment.
There is still a lot of leftover naming from the sign code you copied.
This makes bugs possible thorugh for example your callback where you lock the signs mutex and not the item frames one
|
oops didnt catch that |
| main.items.Item.toBytes(data.item, writer); | ||
| } | ||
|
|
||
| pub fn updateTextFromClient(pos: Vec3i, newText: main.items.Item) void { |
careeoki
left a comment
careeoki
left a comment
There was a problem hiding this comment.
Attempting to put items in frames freezes the game for me, with and without debug mode.
It doesn't crash so I can't show a log.
IntegratedQuantum
moved this from Waiting for artistic review
to WIP/not ready for review
in PRs to review
|
Please wait until the block entity rewrite is finished, to avoid having to migrate the save data. |
|
ok will wait |
|
I like it! Although I think more colors than just green should be possible |
|
Item frames in many colours would be really cool, I agree. Might be a fair bit of work for Crepestrom when Carrie will probably redo the texture anyway. |
7 participants
