Skip to content

902 canvas tracer controllerjs unit tests again PR#905

Open
sbarber2 wants to merge 6 commits intomainfrom
902-canvas_tracer_controllerjs-unit-tests-again
Open

902 canvas tracer controllerjs unit tests again PR#905
sbarber2 wants to merge 6 commits intomainfrom
902-canvas_tracer_controllerjs-unit-tests-again

Conversation

@sbarber2
Copy link
Copy Markdown
Member

@sbarber2 sbarber2 commented Apr 9, 2026

@simsong requesting review before merge because Claude transformed canvas_tracer_controller from a .js to a .mjs so thought it worth a second look.

@sbarber2 sbarber2 requested a review from simsong April 9, 2026 11:10
@sbarber2 sbarber2 self-assigned this Apr 9, 2026
@sbarber2 sbarber2 linked an issue Apr 9, 2026 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.43%. Comparing base (a279cc9) to head (c5eeaac).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #905      +/-   ##
==========================================
+ Coverage   70.53%   72.43%   +1.89%     
==========================================
  Files          48       49       +1     
  Lines        5192     5673     +481     
  Branches      273      375     +102     
==========================================
+ Hits         3662     4109     +447     
- Misses       1398     1432      +34     
  Partials      132      132              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sbarber2 sbarber2 changed the title 902 canvas tracer controllerjs unit tests again 902 canvas tracer controllerjs unit tests again PR Apr 9, 2026
sbarber2 and others added 4 commits April 9, 2026 16:23
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…reate_marker_table, put_markers, marker_name_changed, add_marker_onclick_handler, graph_data #902

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@sbarber2
Copy link
Copy Markdown
Member Author

I think all this looks good. I'm holding off merging so we can coordinate the changes to canvas_tracer_controller.[m]js between this PR and PR #903

@simsong
Copy link
Copy Markdown
Member

simsong commented Apr 13, 2026

we were having so many problems with the fake jquery, I switched back to real jquery. It caused a bunch of changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

canvas_tracer_controller.js unit tests again

2 participants