902 canvas tracer controllerjs unit tests again PR#905
Open
902 canvas tracer controllerjs unit tests again PR#905
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #905 +/- ##
==========================================
+ Coverage 70.53% 72.43% +1.89%
==========================================
Files 48 49 +1
Lines 5192 5673 +481
Branches 273 375 +102
==========================================
+ Hits 3662 4109 +447
- Misses 1398 1432 +34
Partials 132 132 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…reate_marker_table, put_markers, marker_name_changed, add_marker_onclick_handler, graph_data #902 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
Author
|
I think all this looks good. I'm holding off merging so we can coordinate the changes to canvas_tracer_controller.[m]js between this PR and PR #903 |
Member
|
we were having so many problems with the fake jquery, I switched back to real jquery. It caused a bunch of changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@simsong requesting review before merge because Claude transformed canvas_tracer_controller from a .js to a .mjs so thought it worth a second look.