-
Notifications
You must be signed in to change notification settings - Fork 2
Fix retrace2 #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix retrace2 #911
Changes from all commits
9cd4756
738a494
277affe
d445ea4
7104bd1
4b1402a
d5532cd
f2a8b16
3a86747
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,7 +15,7 @@ TS_FILES := $(wildcard *.ts */*.ts) | |
| JS_FILES := $(TS_FILES:.ts=.js) | ||
| LOCAL_BUCKET:=planttracer-local | ||
| LOCAL_HTTP_PORT=8080 | ||
| LOCAL_LAMBDA_PORT=9001 | ||
| LOCAL_LAMBDA_PORT=9811 | ||
| LOCAL_LAMBDA_BASE=http://127.0.0.1:$(LOCAL_LAMBDA_PORT)/ | ||
| DYNAMODB_LOCAL_ENDPOINT=http://localhost:8000/ | ||
| MINIO_ENDPOINT=http://localhost:9000/ | ||
|
|
@@ -315,10 +315,10 @@ bin/DynamoDBLocal.jar: bin/dynamodb_local_latest.zip | |
|
|
||
| # operation: | ||
| start_local_dynamodb: bin/DynamoDBLocal.jar | ||
| bash bin/local_dynamodb_control.bash start | ||
| python3 bin/local_services.py dynamodb start | ||
|
|
||
| stop_local_dynamodb: bin/DynamoDBLocal.jar | ||
| bash bin/local_dynamodb_control.bash stop | ||
| python3 bin/local_services.py dynamodb stop | ||
|
Comment on lines
+318
to
+321
|
||
|
|
||
| list-tables: | ||
| $(LOCAL_AWS_ENV) aws dynamodb list-tables | ||
|
|
@@ -367,10 +367,10 @@ bin/minio: | |
|
|
||
| # operation: | ||
| start_local_minio: bin/minio | ||
| bash bin/local_minio_control.bash start | ||
| python3 bin/local_services.py minio start | ||
|
|
||
| stop_local_minio: bin/minio | ||
| bash bin/local_minio_control.bash stop | ||
| python3 bin/local_services.py minio stop | ||
|
|
||
| list-local-buckets: | ||
| $(LOCAL_AWS_ENV) aws s3 ls | ||
|
|
||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI now starts local DynamoDB/MinIO via
python3 bin/local_services.py ..., butbin/local_services.pyis not present in the repo. This will cause the workflow to fail immediately. Add/commit the script (or revert to the previous start commands) so CI can bring up its local services.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added