Skip to content

Feat: alternative last observations component, with list + map#3996

Open
edelclaux wants to merge 21 commits intoPnX-SI:developfrom
naturalsolutions:feat/create-home-content-display-list
Open

Feat: alternative last observations component, with list + map#3996
edelclaux wants to merge 21 commits intoPnX-SI:developfrom
naturalsolutions:feat/create-home-content-display-list

Conversation

@edelclaux
Copy link
Copy Markdown
Contributor

@edelclaux edelclaux commented Mar 18, 2026

Closes #3735

Le contenu de cette PR est bien décrit dans l'issue.

Il s'agit d'un développement carte liste plutôt classique, avec pas de difficulté particulière à mon avis.
Composants en standalone, encapsulation des sous éléments, ajout d'options dans la config, etc.

Side dev: un petit changement a été appliqué au fichier "frontend/src/app/shared/syntheseSharedModule/synthese-info-obs-container.component.ts"

L'objectif: au lieu que la popup utilise back quand on la quitte, ce qui amène parfois à quitter la page de la synthèse, la popup revient désormais sur la synthèse. Je ne crois pas que ça entraine de régression particulière.
pourquoi cette modif ? comme ça je peux depuis la home mettre un lien vers la popup de l'observation, sans que ça fasse des A/R entre home et synthese.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.60%. Comparing base (0d51c74) to head (ecf20d3).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3996      +/-   ##
===========================================
+ Coverage    86.59%   86.60%   +0.01%     
===========================================
  Files          138      138              
  Lines        10881    10892      +11     
===========================================
+ Hits          9422     9433      +11     
  Misses        1459     1459              
Flag Coverage Δ
pytest 86.60% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@edelclaux edelclaux force-pushed the feat/create-home-content-display-list branch from 823568b to f61fa62 Compare March 25, 2026 23:54
@edelclaux edelclaux force-pushed the feat/create-home-content-display-list branch from 3193ab4 to 3a7907b Compare March 26, 2026 10:05
@edelclaux edelclaux marked this pull request as ready for review March 26, 2026 12:11
@edelclaux edelclaux changed the title Feat: create home content display list Feat: alternative last observations component, with list + map Mar 26, 2026
@edelclaux
Copy link
Copy Markdown
Contributor Author

avant validation de cette PR, on peut se poser la question de ce qu'on fait de l'existant. Je n'y ai pas touché, mais on peut ptet fusionner des choses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant