Feat: alternative last observations component, with list + map#3996
Open
edelclaux wants to merge 21 commits intoPnX-SI:developfrom
Open
Feat: alternative last observations component, with list + map#3996edelclaux wants to merge 21 commits intoPnX-SI:developfrom
edelclaux wants to merge 21 commits intoPnX-SI:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3996 +/- ##
===========================================
+ Coverage 86.59% 86.60% +0.01%
===========================================
Files 138 138
Lines 10881 10892 +11
===========================================
+ Hits 9422 9433 +11
Misses 1459 1459
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
823568b to
f61fa62
Compare
3193ab4 to
3a7907b
Compare
Contributor
Author
|
avant validation de cette PR, on peut se poser la question de ce qu'on fait de l'existant. Je n'y ai pas touché, mais on peut ptet fusionner des choses. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3735
Le contenu de cette PR est bien décrit dans l'issue.
Il s'agit d'un développement carte liste plutôt classique, avec pas de difficulté particulière à mon avis.
Composants en standalone, encapsulation des sous éléments, ajout d'options dans la config, etc.
Side dev: un petit changement a été appliqué au fichier "frontend/src/app/shared/syntheseSharedModule/synthese-info-obs-container.component.ts"
L'objectif: au lieu que la popup utilise back quand on la quitte, ce qui amène parfois à quitter la page de la synthèse, la popup revient désormais sur la synthèse. Je ne crois pas que ça entraine de régression particulière.
pourquoi cette modif ? comme ça je peux depuis la home mettre un lien vers la popup de l'observation, sans que ça fasse des A/R entre home et synthese.