feat(metadata): allow multiple objectifs for one dataset#4103
Draft
VincentCauchois wants to merge 10 commits intodevelopfrom
Draft
feat(metadata): allow multiple objectifs for one dataset#4103VincentCauchois wants to merge 10 commits intodevelopfrom
VincentCauchois wants to merge 10 commits intodevelopfrom
Conversation
VincentCauchois
added
enhancement
database
frontend
backend
javascript
VincentCauchois
force-pushed
the
feat/allow-multiple-objectifs-for-one-dataset
branch
from
84016ec to
a614d56
Compare
3 tasks
VincentCauchois
force-pushed
the
feat/allow-multiple-objectifs-for-one-dataset
branch
2 times, most recently
from
ba04557 to
0ce67e2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4103 +/- ##
===========================================
+ Coverage 86.59% 86.60% +0.01%
===========================================
Files 138 138
Lines 10881 10881
===========================================
+ Hits 9422 9424 +2
+ Misses 1459 1457 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
VincentCauchois
force-pushed
the
feat/allow-multiple-objectifs-for-one-dataset
branch
18 times, most recently
from
2e5ab79 to
cef0c69
Compare
- Finalize taking inspiration from references to "cor_acquisition_framework_objectif":
- Update, if necessary, sample data SQL and Alembic files not refering to "cor_dataset_objectif"
- "backend/geonature/migrations/data/imports/sample_data.sql"
- "backend/geonature/migrations/versions/imports/a81f74d0a518_insert_import_sample_data.py"
- "backend/geonature/tests/data/delete_sample_data.sql"
- "contrib/occtax/backend/occtax/migrations/2a0ab7644e1c_occtax_sample_test.py"
- "contrib/occtax/backend/occtax/migrations/cce08a64eb4f_insert_occtax_sample_data.py"
- "contrib/occtax/backend/occtax/migrations/data/sample_data_test.sql"
- "contrib/occtax/backend/occtax/migrations/data/sample_data.sql"
- Take inspiration from "docs/data_model/gn_meta/cor_acquisition_framework_objectif.sql"
- Finalize getting rid of possibly outdated references, or taking inspiration from possibly still relevant ones, to "id_nomenclature_dataset_objectif":
- "backend/geonature/migrations/data/core/meta.sql"
- "backend/geonature/migrations/data/imports/sample_data.sql"
- "backend/geonature/tests/data/sample_data.sql"
- "contrib/gn_module_occhab/backend/gn_module_occhab/migrations/data/sample_data.sql"
- "contrib/occtax/backend/occtax/migrations/data/sample_data_test.sql"
- "contrib/occtax/backend/occtax/migrations/data/sample_data.sql"
- "data/migrations/2.0.0beta4-to-2.0.0beta5.sql"
- "docs/data_model/gn_meta/t_datasets.sql"
- Check for "docs/_static/2019-08-GN2-1-MCD.svg" which unexpectedly refers to af and ds objectif
- (?) Add missing backend and frontend tests
Verify it does not break frontend tests.
VincentCauchois
force-pushed
the
feat/allow-multiple-objectifs-for-one-dataset
branch
from
af66bf2 to
3895d74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #4102
ref_nomenclatures.get_default_nomenclature_value('JDD_OBJECTIFS')