Skip to content

Add normalized form submission context - #1292

Closed
danieliser wants to merge 45 commits into
developfrom
feature/form-submission-context
Closed

Add normalized form submission context#1292
danieliser wants to merge 45 commits into
developfrom
feature/form-submission-context

Conversation

@danieliser

@danieliser danieliser commented Aug 7, 2026

Copy link
Copy Markdown
Member

Summary

  • extend Popup Maker's normalized PHP and JavaScript form-submission contracts with provider submission IDs, source post IDs, and extension-owned context
  • add pum.integration.form.submissionArgs so extensions can enrich every provider through one frontend integration point
  • populate the new server-side identifiers for Fluent Forms without coupling Core to Content Upgrades
  • document and test the backward-compatible defaults and extension context flow

Why

This is the small Core boundary needed by PopupMaker/Pro#127. Core remains unaware of Incentives, Assets, and Delivery; Pro consumes the normalized submission metadata.

Validation

  • focused PHPCS: 0 errors (the existing integration registry reports its pre-existing alignment warnings)
  • changed JavaScript file lint: pass (the already-touched legacy file was mechanically updated to current syntax so changed-file CI can enforce the repository rules)
  • normalized PHP context exercised successfully in the linked Pro wp-env
  • regression tests added in FormSubmissionContext_Test.php

Linked work

  • PopupMaker/Pro#129 depends on this PR

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 32f55926-c582-468a-b22b-79e95ecf9831

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

danieliser and others added 28 commits August 7, 2026 07:36

Copy link
Copy Markdown
Member Author

Tracking issue: #1357. This draft should remain the minimal, product-neutral normalized submission-context seam for the Pro forms platform epic PopupMaker/Pro#132. Product-specific tokens, storage, mappings, actions, subscribers, and Lead Magnet behavior are out of scope. If the merge-heavy history cannot be cleaned safely, replace this PR from a fresh feature branch while preserving the tested contract.

@danieliser

Copy link
Copy Markdown
Member Author

Superseded by clean draft #1359. The replacement preserves the product-neutral contract, adds source URL and focused JavaScript coverage, and avoids this branch's merge-heavy history.

@danieliser danieliser closed this Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant