Performance: reduce memory and TTFB on general admin screens

classes/Admin.php

@@ -10,34 +10,125 @@ class PUM_Admin {
 
 	public static function init() {
 		PUM_Admin_BlockEditor::init();
+		self::register_request_actions();
+		self::register_lazy_save_hooks();
 
 		if ( is_admin() ) {
+			self::register_upsell_preview_hooks();
+
+			if ( ! wp_doing_ajax() ) {
+				PUM_Admin_Shortcode_UI::init();
+			}
+
 			PUM_Admin_Pages::init();
-			PUM_Admin_Extend::init();
 			PUM_Admin_Ajax::init();
 			PUM_Admin_Assets::init();
 			PUM_Admin_Notices::init();
+			PUM_Admin_Onboarding::init();
 		}
 
-		if ( is_admin() ) {
+		add_filter( 'user_has_cap', [ __CLASS__, 'prevent_default_theme_deletion' ], 10, 3 );
+		add_action( 'admin_init', [ __CLASS__, 'after_install' ] );
+		add_action( 'admin_head', [ __CLASS__, 'clean_ui' ] );
+	}
+
+	/**
+	 * Register request actions before the init dispatcher runs.
+	 *
+	 * Keeping these lightweight class-string callbacks here avoids loading the
+	 * Tools screen while ensuring PUM_Site::actions() can dispatch them on init.
+	 *
+	 * @return void
+	 */
+	private static function register_request_actions() {
+		add_action( 'pum_save_enabled_betas', [ 'PUM_Admin_Tools', 'save_enabled_betas' ] );
+		add_action( 'pum_empty_error_log', [ 'PUM_Admin_Tools', 'error_log_empty' ] );
+	}
+
+	/**
+	 * Register premium preview hooks without loading the screen UI implementation.
+	 *
+	 * Trigger and condition registries may be materialized before admin_menu, so
+	 * these class-string callbacks must exist during the initial admin bootstrap.
+	 *
+	 * @return void
+	 */
+	private static function register_upsell_preview_hooks() {
+		if ( defined( 'POPUP_MAKER_DISABLE_UPSELLS' ) && POPUP_MAKER_DISABLE_UPSELLS ) {
+			return;
+		}
+
+		if ( \PopupMaker\plugin()->is_pro_active() ) {
+			return;
+		}
+
+		add_filter( 'pum_registered_triggers', [ 'PUM_Upsell', 'register_preview_triggers' ] );
+		add_filter( 'pum_registered_conditions', [ 'PUM_Upsell', 'register_preview_conditions' ] );
+		add_filter( 'popup_maker/cta_types_as_array', [ 'PUM_Upsell', 'register_preview_cta_types' ] );
+		add_action( 'pum_popup_analytics_metabox_after', [ 'PUM_Upsell', 'render_analytics_teaser' ] );
+		add_filter( 'pum_admin_vars', [ 'PUM_Upsell', 'localize_premium_preview_data' ] );
+	}
+
+	/**
+	 * Initialize admin components used by the current request.
+	 *
+	 * @param array<string,string> $page_slugs Resolved admin page slugs.
+	 *
+	 * @return void
+	 */
+	public static function init_request_components( $page_slugs ) {
+		$post_type  = pum_typenow();
+		$page       = self::requested_page();
+		$page_slugs = is_array( $page_slugs ) ? $page_slugs : [];
+
+		if ( 'popup' === $post_type ) {
 			PUM_Admin_Popups::init();
+		}
+
+		if ( 'popup_theme' === $post_type ) {
 			PUM_Admin_Themes::init();
+		}
+
+		if ( isset( $page_slugs['subscribers'] ) && $page_slugs['subscribers'] === $page ) {
 			PUM_Admin_Subscribers::init();
+		}
+
+		if ( isset( $page_slugs['settings'] ) && $page_slugs['settings'] === $page ) {
 			PUM_Admin_Settings::init();
+		}
+
+		if ( isset( $page_slugs['tools'] ) && $page_slugs['tools'] === $page ) {
 			PUM_Admin_Tools::init();
-			PUM_Admin_Shortcode_UI::init();
+		}
+
+		if ( isset( $page_slugs['extensions'] ) && $page_slugs['extensions'] === $page ) {
+			PUM_Admin_Extend::init();
+		}
+
+		if ( in_array( $post_type, [ 'popup', 'popup_theme' ], true ) || in_array( $page, $page_slugs, true ) || 'popup-maker-call-to-actions' === $page ) {
 			PUM_Upsell::init();
-			PUM_Admin_Onboarding::init();
-		} else {
-			// Preserve programmatic saves without loading the editor classes on every frontend request.
-			add_action( 'save_post', [ 'PUM_Admin_Popups', 'save' ], 10, 2 );
-			add_filter( 'wp_insert_post_data', [ 'PUM_Admin_Popups', 'set_slug' ], 99, 2 );
-			add_action( 'save_post', [ 'PUM_Admin_Themes', 'save' ], 10, 2 );
 		}
+	}
 
-		add_filter( 'user_has_cap', [ __CLASS__, 'prevent_default_theme_deletion' ], 10, 3 );
-		add_action( 'admin_init', [ __CLASS__, 'after_install' ] );
-		add_action( 'admin_head', [ __CLASS__, 'clean_ui' ] );
+	/**
+	 * Register save callbacks without loading their editor implementations.
+	 *
+	 * @return void
+	 */
+	private static function register_lazy_save_hooks() {
+		add_action( 'save_post', [ 'PUM_Admin_Popups', 'save' ], 10, 2 );
+		add_filter( 'wp_insert_post_data', [ 'PUM_Admin_Popups', 'set_slug' ], 99, 2 );
+		add_action( 'save_post', [ 'PUM_Admin_Themes', 'save' ], 10, 2 );
+	}
+
+	/**
+	 * Get the requested plugin page slug.
+	 *
+	 * @return string
+	 */
+	private static function requested_page() {
+		// phpcs:ignore WordPress.Security.NonceVerification.Recommended
+		return isset( $_GET['page'] ) ? sanitize_key( wp_unslash( $_GET['page'] ) ) : '';
 	}
 
 	/**

classes/Admin/Ajax.php

@@ -24,6 +24,8 @@ public static function init() {
 		add_action( 'wp_ajax_pum_object_search', [ __CLASS__, 'object_search' ] );
 		add_action( 'wp_ajax_pum_process_batch_request', [ __CLASS__, 'process_batch_request' ] );
 		add_action( 'wp_ajax_pum_save_enabled_state', [ __CLASS__, 'save_popup_enabled_state' ] );
+		add_action( 'wp_ajax_pum_get_css_styles', [ 'PUM_Admin_Settings', 'ajax_get_css_styles' ] );
+		add_action( 'wp_ajax_pum_do_shortcode', [ 'PUM_Admin_Shortcode_UI', 'do_shortcode' ] );
 	}
 
 	/**