Performance: reduce Popup Editor memory and TTFB - #1317
Conversation
2588c53 to
cd066c6
Compare
0ddbaef to
5d7304e
Compare
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughPopup Maker now injects editor styles through TinyMCE and block-editor filters. It also preserves filtered popup models or returns reduced ChangesEditor integration and popup localization
Estimated code review effort: 3 (Moderate) | ~20 minutes Mergeability Score: 🟡 Moderate · up to The performance changes are otherwise well validated, but one focused regression test uses a filter that this data path does not execute, so its expected localized title is not actually verified; merge should wait for that test to be corrected or explicitly accepted. Sequence Diagram(s)sequenceDiagram
participant PUM_Admin_Shortcode_UI
participant TinyMCE
participant BlockEditor
participant LocalCSSFiles
PUM_Admin_Shortcode_UI->>TinyMCE: Add editor stylesheet URLs
TinyMCE-->>PUM_Admin_Shortcode_UI: Return filtered CSS list
PUM_Admin_Shortcode_UI->>BlockEditor: Add local CSS to editor settings
BlockEditor->>LocalCSSFiles: Read stylesheet contents
LocalCSSFiles-->>BlockEditor: Return theme styles
sequenceDiagram
participant BlockEditor
participant AssetsController
participant PUM_Helpers
BlockEditor->>AssetsController: Request popup localization data
alt Localization filter has callbacks
AssetsController-->>BlockEditor: Return full popup models
else No localization filter callbacks
AssetsController->>PUM_Helpers: Build popup_selectlist choices
PUM_Helpers-->>AssetsController: Return ID and post_title choices
AssetsController-->>BlockEditor: Return reduced popup data
end
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d7304ee8a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
c5d6a82 to
3f7cc9f
Compare
5675929 to
72b2069
Compare
72b2069 to
d2bbec0
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d2bbec04e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d2bbec0 to
484de20
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 484de201dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
4b78607 to
7b55833
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7b558335de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
7b55833 to
6f63849
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
6f63849 to
f6babed
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f6babed14d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f6babed to
f0bac7c
Compare
|
@codex review |
|
@codex review |
|
@coderabbitai full review |
|
a0399b2 to
826092d
Compare
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
@coderabbitai full review |
|
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review the exact current head, including the readable-private popup compatibility change. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 826092dc63
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
242e61e to
2504f6b
Compare
|
@codex review |
1 similar comment
|
@codex review |
2504f6b to
05cfcf2
Compare
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
6e119db to
a2cd5cb
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
974be17 to
b62bb80
Compare
|
@codex review |
47921f1 to
9e0b4ce
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Status: sequence-gated draft
Do not merge #1317 yet. #1316 must merge first; then this branch must be rebased onto the resulting
developand all exact-head gates rerun. Current checks provide evidence for the two-commit #1354 live-test draft only.Summary
Popup Editor performance change based directly on the shared popup-query foundation merged in #1356.
{ ID, post_title }choices only for the block-editor package.PUM_Helpers::popup_selectlist()output directly; it performs no private query or per-ID post lookup/validation.popup_maker/block-editor_localized_vars, including priority-0registrations.Merge sequencing
#1316 owns the Components localization used by
PopupSelectControl; this PR owns the separate block-editor payload and editor styles. On the current base, #1317 avoids the second full-model localization but Components still hydrates those models once. Merge #1316 first, then rebase this branch on the resultingdevelopbefore merging #1317. The draft #1354 contains both exact patches for combined validation. Duplicating Components ownership here would recreate the overlap these PRs intentionally removed.Exact scope
develop@c972387c2b5fb5e76ba8467cf9d6c34127b9d9b6826092dc637b30c02feb5d05cca04cb43f1e2a6fVerification
git diff --check: passed.get_posts(), directWP_Query,$wpdb, or per-popupget_post_type()in this PR.Ablation retained
Focused regressions preserve the independently necessary behaviors: lightweight block-editor shaping, readable private choices, supported title-choice filtering, full-model extension fallback, TinyMCE stylesheet registration, local block-editor CSS injection, and RTL/LTR selection.