Announce complete page builder support in admin - #1338
Conversation
|
@codex review |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe PR adds metadata to supported page builders, exposes available builder adapters, and registers ChangesPage-builder announcements
Estimated code review effort: 3 (Moderate) | ~25 minutes Mergeability Score: ⚪ Minimal · up to This change adds a consolidated, dismissible page-builder support announcement without any actionable merge-blocking risk remaining after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant Manager
participant PageBuilderAnnouncements
participant Builders
participant AlertList
Manager->>PageBuilderAnnouncements: resolve and initialize provider
PageBuilderAnnouncements->>AlertList: register pum_alert_list callback
AlertList->>PageBuilderAnnouncements: provide alert list
PageBuilderAnnouncements->>Builders: get available builders
Builders-->>PageBuilderAnnouncements: return registered builder adapters
PageBuilderAnnouncements-->>AlertList: append dismissible builder announcement
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…ts' into feature/page-builder-announcements
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
What changed
User impact
Users with Elementor, Beaver Builder, SiteOrigin Page Builder, Brizy, Visual Composer, Divi, Bricks, or Etch will discover that Popup Maker now supports designing popup content in their preferred builder. Sites using several builders receive one concise announcement rather than one notice per builder.
Validation
composer run tests— 999 tests, 2,224 assertions, 43 skippedgit diff --check— cleanSummary by CodeRabbit
New Features
Tests