Skip to content

Announce complete page builder support in admin - #1338

Open
danieliser wants to merge 33 commits into
developfrom
feature/page-builder-announcements
Open

Announce complete page builder support in admin#1338
danieliser wants to merge 33 commits into
developfrom
feature/page-builder-announcements

Conversation

@danieliser

@danieliser danieliser commented Aug 12, 2026

Copy link
Copy Markdown
Member

What changed

  • Added one dismissible feature announcement when one or more supported page builders are active.
  • Reused the builder controller's booted adapters instead of duplicating detection or autoloading inactive integrations.
  • Consolidated mixed-builder sites into a single notification and scoped dismissal to the active builder set.
  • Added notification registry documentation, a user-facing changelog entry, and PHPUnit coverage.

User impact

Users with Elementor, Beaver Builder, SiteOrigin Page Builder, Brizy, Visual Composer, Divi, Bricks, or Etch will discover that Popup Maker now supports designing popup content in their preferred builder. Sites using several builders receive one concise announcement rather than one notice per builder.

Validation

  • composer run tests — 999 tests, 2,224 assertions, 43 skipped
  • Targeted builder/notification tests — 25 tests, 112 assertions
  • PHPCS — clean
  • PHPStan with 1 GB memory limit — clean
  • git diff --check — clean

Summary by CodeRabbit

  • New Features

    • Added dismissible admin announcements for supported page builders.
    • Announcements identify available builders and link to relevant documentation.
    • Added consistent names and identifiers for supported page-builder integrations.
    • Announcements are shown only to users who can edit popups.
    • Exposed currently available page builders for broader application use.
  • Tests

    • Added coverage for builder detection, permissions, announcement content, and multiple-builder scenarios.

@danieliser

Copy link
Copy Markdown
Member Author

@codex review

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0c0a5870-31f3-4654-bf0c-664fad8671c8

📥 Commits

Reviewing files that changed from the base of the PR and between 1567d6a and c5d471b.

📒 Files selected for processing (1)
  • docs/notifications-registry.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/notifications-registry.md

Walkthrough

The PR adds metadata to supported page builders, exposes available builder adapters, and registers PageBuilderAnnouncements. The provider creates permission-checked, dismissible alerts with builder-specific messaging and documentation links. Tests and registry documentation cover the behavior.

Changes

Page-builder announcements

Layer / File(s) Summary
Builder metadata and availability API
classes/Base/PageBuilder.php, classes/Builders/*, classes/Controllers/Builders.php, tests/php/tests/Page_Builders_Test.php
Builder adapters define stable keys and labels. The builders controller exposes available adapters. Tests verify the returned builder data.
Announcement provider and integration
classes/Services/Notifications/PageBuilderAnnouncements.php, classes/Services/Notifications/Manager.php, tests/php/tests/Page_Builder_Announcements_Test.php, docs/notifications-registry.md
The provider detects available builders, checks permissions and inputs, creates scoped singular or plural alerts, and registers them with the notification manager. Tests and documentation cover the provider.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Mergeability Score: ⚪ Minimal · up to c5d47

This change adds a consolidated, dismissible page-builder support announcement without any actionable merge-blocking risk remaining after normal checks and review.

Sequence Diagram(s)

sequenceDiagram
  participant Manager
  participant PageBuilderAnnouncements
  participant Builders
  participant AlertList
  Manager->>PageBuilderAnnouncements: resolve and initialize provider
  PageBuilderAnnouncements->>AlertList: register pum_alert_list callback
  AlertList->>PageBuilderAnnouncements: provide alert list
  PageBuilderAnnouncements->>Builders: get available builders
  Builders-->>PageBuilderAnnouncements: return registered builder adapters
  PageBuilderAnnouncements-->>AlertList: append dismissible builder announcement
Loading

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: an admin announcement for supported page builders.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/page-builder-announcements

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: ce4a045541

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@danieliser

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 8bf9077b1e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant