Remove positronic/robot_controller.py - #635
Merged
Merged
Conversation
The interactive prompt for driving one arm by hand had no caller: no module imported it, no test covered it, no doc mentioned it, and it was not a `[project.scripts]` entry. It compiled because rename and refactor sweeps kept fixing it, and it had drifted anyway — it spoke 3 of the 5 roboarm command types, missing `JointDelta` and `CartesianDelta`. Its 8 grandfathered `reportAttributeAccessIssue` entries leave the basedpyright baseline with it. Closes #634
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes
positronic/robot_controller.py, the interactive prompt for driving one arm by hand(
reset/move/joint_move/info/quitoff stdin, defaulting to Kinova).Nothing reached it: no module imported it, no test covered it, no doc mentioned it, and it was not
a
[project.scripts]entry. It compiled because rename and refactor sweeps kept fixing it — themost recent being d5f2a47, which rewrote its
emitcalls for the per-command wire. It had driftedregardless: it spoke 3 of the 5 roboarm command types, with no syntax for
JointDeltaorCartesianDelta.The 8 grandfathered
reportAttributeAccessIssueentries it held in.basedpyright/baseline.jsongo with it, pruned by basedpyright itself.
Closes #634
Test plan
uv run --locked pytest --no-cov— 1441 passed, 9 skippeduv run --locked ruff check .andruff format --check .— cleanbasedpyright— 0 errors; baseline shrank by exactly the 8 entries for the removed file