fix: Add random delay in Listener.cacheReloader#4639
Closed
mkleczek wants to merge 1 commit intoPostgREST:mainfrom
Closed
fix: Add random delay in Listener.cacheReloader#4639mkleczek wants to merge 1 commit intoPostgREST:mainfrom
mkleczek wants to merge 1 commit intoPostgREST:mainfrom
Conversation
mkleczek
force-pushed
the
add-stutter-to-listener-notifications-handling
branch
2 times, most recently
from
a4fb4f7 to
5f0d4be
Compare
Member
|
Note: This is a potential solution to #4642. |
Member
I'm wondering if 1 second is enough considering extreme cases like #4642. |
Collaborator
Author
Yeah, I share your concern. But didn't want to add a new config property. After some more thought: maybe using advisory locks would be a better solution here? |
Collaborator
Author
@steve-chavez - see alternative solution: #4643 |
mkleczek
force-pushed
the
add-stutter-to-listener-notifications-handling
branch
2 times, most recently
from
8a16e68 to
59d8f14
Compare
Triggering schema cache reload immediately upon receival of notification by the listener leads to thundering herd problem in PostgREST cluster. This change adds random delay between 0 and 1 seconds between notification retrieval and schema cache reload triggering.
mkleczek
force-pushed
the
add-stutter-to-listener-notifications-handling
branch
from
59d8f14 to
a3bc057
Compare
Collaborator
Author
|
Superseded by #4643 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triggering schema cache reload immediately upon receival of notification by the listener leads to thundering herd problem in PostgREST cluster.
This change adds random delay between 0 and 1 seconds between notification retrieval and schema cache reload triggering.