Skip to content

test(io): add test_graceful_shutdown_waits_for_in_flight_request #4714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steve-chavez merged 1 commit into from
Mar 12, 2026
Merged

test(io): add test_graceful_shutdown_waits_for_in_flight_request #4714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions test/io/test_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,28 @@ def sleep():
t.join()


@pytest.mark.xfail(reason="Graceful shutdown is currently failing", strict=True)
def test_graceful_shutdown_waits_for_in_flight_request(defaultenv):
"SIGTERM should allow in-flight requests to finish before exiting"

with run(env=defaultenv, wait_max_seconds=5) as postgrest:

def sleep():
response = postgrest.session.get("/rpc/sleep?seconds=3", timeout=10)
assert response.text == ""
assert response.status_code == 204

t = Thread(target=sleep)
t.start()

# Wait for the request to be in-flight before shutting down.
time.sleep(1)

postgrest.process.terminate()

t.join()
Comment on lines +110 to +127
Copy link
Copy Markdown
Member

@steve-chavez steve-chavez Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up on the discussion in #4702 (comment), the pg connection is left running while postgREST shuts down.

I was thinking the right behavior is to also kill the connection immediately.

But on postgres that behavior happens under SIGINT, SIGTERM is the smart shutdown mode (ref). So this looks correct.

Copy link
Copy Markdown
Collaborator Author

@mkleczek mkleczek Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steve-chavez I guess I don't understand how it affects the test itself. Do you want to have different scenarios for SIGINT and SIGTERM?

Copy link
Copy Markdown
Member

@steve-chavez steve-chavez Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it was just a comment so we don't forget (thinking out loud). All good here.



def test_random_port_bound(defaultenv):
"PostgREST should bind to a random port when PGRST_SERVER_PORT is 0."

Expand Down
Loading