Add TACACS Server configuration (Add/Get/Set/Remove) by CedricMoreau · Pull Request #46 · PowerAruba/PowerArubaCX

CedricMoreau · 2021-11-30T08:58:45Z

No description provided.

PowerArubaCX/Private/Confirm.ps1

alagoutte · 2021-11-30T11:27:42Z

PowerArubaCX/Public/Tacacs.ps1

+
+    <#
+        .SYNOPSIS
+        Add Aruba CX Tacacs Server


Tacacs => TACACS (for other after too)

PowerArubaCX/Public/Tacacs.ps1

alagoutte · 2021-11-30T11:28:23Z

PowerArubaCX/Public/Tacacs.ps1

+        [string]$auth_type = "pap",
+        [Parameter (Mandatory = $true)]
+        [ValidateRange(1, 9223372036854775807)]
+        [int]$default_group_priority,


int64 ? (for validateRange)

PowerArubaCX/Public/Tacacs.ps1

Tests/integration/Tacacs.Tests.ps1

alagoutte

Can you also update README(.md) add on list of supported feature/commands and add also some example...

PowerArubaCX/Private/Confirm.ps1

PowerArubaCX/Public/Tacacs.ps1

alagoutte · 2021-11-30T20:04:37Z

PowerArubaCX/Public/Tacacs.ps1

+        Configure TACACS Server (Timeout, port...)
+
+        .EXAMPLE
+        Set-ArubaCXTacacsServer -timeout 15 -address 192.2.0.1 -port 49


All example with Pipeline ?

alagoutte · 2021-11-30T20:06:00Z

PowerArubaCX/Public/Tacacs.ps1

+
+        $_group = @()
+
+        $_group += "/rest/" + $($connection.version) + "/system/aaa_server_groups/" + $group


always needed to be update ?

alagoutte · 2021-11-30T20:06:40Z

PowerArubaCX/Public/Tacacs.ps1

+
+        if ($PSCmdlet.ShouldProcess("Tacacs Server (VRF: ${vrf})", "Remove ${address},${port}")) {
+            Invoke-ArubaCXRestMethod -method "DELETE" -uri $uri -connection $connection
+            Write-Progress -activity "Remove Tacacs Server" -completed


remove this write-progress too

alagoutte · 2021-11-30T20:07:29Z

Tests/integration/Tacacs.Tests.ps1

+. ../common.ps1
+
+Describe "Get TACACS Server" {
+    BeforeALL {


alagoutte · 2021-11-30T20:08:10Z

Tests/integration/Tacacs.Tests.ps1

+
+        It "Get TACACS Server with one attribute (auth_type)" {
+            $tacacs = Get-ArubaCXTacacsServer -address $pester_tacacs_address -port $pester_tacacs_port -attribute auth_type
+            @($tacacs).count | Should -be 1


-be -> -Be (same issue after)

alagoutte · 2021-12-27T13:32:47Z

PowerArubaCX/Public/Tacacs.ps1

+        [Parameter(Mandatory = $false)]
+        [ValidateRange(1, 4)]
+        [Int]$depth,
+        [Parameter(Mandatory = $false, ParameterSetName = "address")]


Why parameter set ?

alagoutte · 2021-12-27T13:33:06Z

PowerArubaCX/Public/Tacacs.ps1

+        [Parameter (Mandatory = $true, ParameterSetName = "address")]
+        [ipaddress]$address,
+        [Parameter (Mandatory = $false)]
+        [int]$port = 49,


missing parameter set name for port ?

alagoutte · 2021-12-27T13:33:53Z

PowerArubaCX/Public/Tacacs.ps1

+    [CmdletBinding(DefaultParametersetname = "Default")]
+    Param(
+        [Parameter (Mandatory = $true, ParameterSetName = "address")]
+        [ipaddress]$address,


TACACS can't be a FQDN ?

alagoutte · 2021-12-27T13:34:59Z

PowerArubaCX/Public/Tacacs.ps1

+
+        $uri = "system/vrfs/${vrf}/tacacs_servers/${address},${port}"
+
+        if ($PSCmdlet.ShouldProcess("Tacacs Server (VRF: ${vrf})", "Remove ${address},${port}")) {


TACACS Server

README.md

alagoutte · 2021-12-27T13:36:20Z

README.md

+    Get-ArubaCXTacacsServer -address 192.2.0.1 | Remove-ArubaCXTacacsServer
+```
+
+For configure a vlan to an interface, need to use [Set-ArubaCXInterfaces](#Interface)


alagoutte

Need to fix some stuff before merge

alagoutte · 2022-01-24T19:51:03Z

PowerArubaCX/Public/Tacacs.ps1

+            }
+        }
+
+        $response = Invoke-ArubaCXRestMethod -uri $uri -method 'POST' -body $_tacacs -connection $connection


remove $response

alagoutte · 2022-01-24T19:52:22Z

README.md

+
+
+# Remove a TACACS Server
+    Get-ArubaCXTacacsServer -address 192.2.0.1 | Remove-ArubaCXTacacsServer


add example of remove...

alagoutte · 2022-01-24T19:52:58Z

Tests/common.ps1

 $script:pester_lag = "2" #lag id for test...
 $script:pester_loopback = "2" #loopback id for test...
 $script:pester_vrf = "pester_vrf" #interface id for test...
+$script:pester_tacacs_address = "192.2.0.1"


it is 192.0.2.0/24 for example network

alagoutte · 2022-01-24T19:53:08Z

Tests/integration/Tacacs.Tests.ps1

@@ -0,0 +1,227 @@
+#
+# Copyright 2020, Cédric Moreau <moreaucedric0 at gmail dot com>


Copyright :D

alagoutte · 2022-01-24T19:54:06Z

Tests/integration/Tacacs.Tests.ps1

+
+    Context "Search" {
+        It "Search TACACS Server by address ($pester_tacacs_address)" {
+            $tacacs = Get-ArubaCXTacacsServer -address $pester_tacacs_address -port $pester_tacacs_port


add search without port

and also with position = 1

alagoutte · 2025-01-22T12:26:27Z

any update @CedricMoreau ? :)

alagoutte changed the title ~~Add Tacacs Server configuration (Add/Get/Set/Remove)~~ Add TACACS Server configuration (Add/Get/Set/Remove) Nov 30, 2021

alagoutte requested changes Nov 30, 2021

View reviewed changes

alagoutte reviewed Dec 27, 2021

View reviewed changes

README.md Show resolved Hide resolved

alagoutte reviewed Dec 27, 2021

View reviewed changes

alagoutte requested changes Dec 27, 2021

View reviewed changes

alagoutte force-pushed the tacacs branch from d49c257 to 0097073 Compare December 27, 2021 13:38

Cédric Moreau and others added 7 commits January 24, 2022 18:58

Add Tacacs Server configuration (Add/Get/Set/Remove)

eebf665

Add TacacsServer cmdlets (Add/Get/Set/Remove)

32cf0ad

Fix after review

b9fbab2

Fix typos, and change depth of Get function

1cfe0e4

Fix some mandatory parameters

6089826

Remove whitespaces and save with utf8-bom

541689d

TACACS(Tests): Use BeforeALL for Pester V5 Discovery

1d4e24c

alagoutte force-pushed the tacacs branch from 0097073 to 1d4e24c Compare January 24, 2022 17:59

alagoutte reviewed Jan 24, 2022

View reviewed changes


		$_group = @()

		$_group += "/rest/" + $($connection.version) + "/system/aaa_server_groups/" + $group


		$uri = "system/vrfs/${vrf}/tacacs_servers/${address},${port}"

		if ($PSCmdlet.ShouldProcess("Tacacs Server (VRF: ${vrf})", "Remove ${address},${port}")) {



		# Remove a TACACS Server
		Get-ArubaCXTacacsServer -address 192.2.0.1 \| Remove-ArubaCXTacacsServer

		@@ -0,0 +1,227 @@
		#
		# Copyright 2020, Cédric Moreau <moreaucedric0 at gmail dot com>

Conversation

CedricMoreau commented Nov 30, 2021

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alagoutte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alagoutte left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alagoutte commented Jan 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants