fix: don't change graph on incorrect call to tmp_remove_nodes#266
Open
vincentkoppen wants to merge 4 commits into
Open
fix: don't change graph on incorrect call to tmp_remove_nodes#266vincentkoppen wants to merge 4 commits into
vincentkoppen wants to merge 4 commits into
Conversation
Signed-off-by: Vincent Koppen <vincent.koppen@alliander.com>
Signed-off-by: Vincent Koppen <vincent.koppen@alliander.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
tmp_remove_nodeswas called with a non-existing node, this could change the graph afterwards.This PR fixes that by always keeping track of the which nodes are removed and then always restoring these (and the relevant edges)
PS: review is probably easiest with "hide whitespaces" on for the tests, since I introduced a class for the
tmp_remove_nodestests and github doesn't generate a nice diff unfortunately