Skip to content

Remove excessive and wrong use of std::forward #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TonyXiang8787 wants to merge 12 commits into
base: main
Choose a base branch
from

Merge branch 'main' into pgm/remove-forward

c6fea3b
Select commit
Loading
Failed to load commit list.
Open

Remove excessive and wrong use of std::forward #1401

Merge branch 'main' into pgm/remove-forward
c6fea3b
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 19, 2026 in 21m 13s

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 289 in power_grid_model_c/power_grid_model/include/power_grid_model/main_core/update.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"std::forward" is never called on this forwarding reference argument. 

See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AZ47UwT6zbV7Z3PiMmfZ&open=AZ47UwT6zbV7Z3PiMmfZ&pullRequest=1401

Check failure on line 317 in power_grid_model_c/power_grid_model/include/power_grid_model/main_core/update.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"std::forward" is never called on this forwarding reference argument. 

See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AZ47UwT7zbV7Z3PiMmfb&open=AZ47UwT7zbV7Z3PiMmfb&pullRequest=1401

Check failure on line 209 in power_grid_model_c/power_grid_model/include/power_grid_model/main_core/update.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"std::forward" is never called on this forwarding reference argument. 

See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AZ47UwT6zbV7Z3PiMmfX&open=AZ47UwT6zbV7Z3PiMmfX&pullRequest=1401

Check failure on line 52 in power_grid_model_c/power_grid_model/include/power_grid_model/job_interface.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"std::forward" is never called on this forwarding reference argument. 

See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AZ47UwWHzbV7Z3PiMmfk&open=AZ47UwWHzbV7Z3PiMmfk&pullRequest=1401

Check warning on line 303 in power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Capture variables by reference, it is safe in this context. 

See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AZ47UwMFzbV7Z3PiMmfU&open=AZ47UwMFzbV7Z3PiMmfU&pullRequest=1401

Check failure on line 51 in power_grid_model_c/power_grid_model/include/power_grid_model/main_core/input.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"std::forward" is never called on this forwarding reference argument. 

See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AZ47UwRJzbV7Z3PiMmfV&open=AZ47UwRJzbV7Z3PiMmfV&pullRequest=1401

Check failure on line 38 in power_grid_model_c/power_grid_model/include/power_grid_model/common/iterator_facade.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"std::forward" is never called on this forwarding reference argument. 

See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AZ47UwVhzbV7Z3PiMmff&open=AZ47UwVhzbV7Z3PiMmff&pullRequest=1401

Check failure on line 20 in power_grid_model_c/power_grid_model/include/power_grid_model/job_interface.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"std::forward" is never called on this forwarding reference argument. 

See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AZ47UwWHzbV7Z3PiMmfg&open=AZ47UwWHzbV7Z3PiMmfg&pullRequest=1401

Check failure on line 40 in power_grid_model_c/power_grid_model/include/power_grid_model/common/grouped_index_vector.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"std::forward" is never called on this forwarding reference argument. 

See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AZ47UwUVzbV7Z3PiMmfc&open=AZ47UwUVzbV7Z3PiMmfc&pullRequest=1401

Check failure on line 265 in power_grid_model_c/power_grid_model/include/power_grid_model/main_core/update.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"std::forward" is never called on this forwarding reference argument. 

See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AZ47UwT6zbV7Z3PiMmfY&open=AZ47UwT6zbV7Z3PiMmfY&pullRequest=1401

Check failure on line 34 in power_grid_model_c/power_grid_model/include/power_grid_model/job_interface.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"std::forward" is never called on this forwarding reference argument. 

See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AZ47UwWHzbV7Z3PiMmfi&open=AZ47UwWHzbV7Z3PiMmfi&pullRequest=1401

Check warning on line 339 in power_grid_model_c/power_grid_model/include/power_grid_model/common/three_phase_tensor.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"std::move" is never called on this rvalue reference argument. 

See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AZ47UwUmzbV7Z3PiMmfe&open=AZ47UwUmzbV7Z3PiMmfe&pullRequest=1401

Check failure on line 29 in power_grid_model_c/power_grid_model/include/power_grid_model/job_interface.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"std::forward" is never called on this forwarding reference argument. 

See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AZ47UwWHzbV7Z3PiMmfh&open=AZ47UwWHzbV7Z3PiMmfh&pullRequest=1401

Check failure on line 43 in power_grid_model_c/power_grid_model/include/power_grid_model/job_interface.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"std::forward" is never called on this forwarding reference argument. 

See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AZ47UwWHzbV7Z3PiMmfj&open=AZ47UwWHzbV7Z3PiMmfj&pullRequest=1401

Check failure on line 119 in power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"std::forward" is never called on this forwarding reference argument. 

See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AZ47UwMFzbV7Z3PiMmfS&open=AZ47UwMFzbV7Z3PiMmfS&pullRequest=1401

Check failure on line 140 in power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"std::forward" is never called on this forwarding reference argument. 

See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AZ47UwMFzbV7Z3PiMmfT&open=AZ47UwMFzbV7Z3PiMmfT&pullRequest=1401

Check failure on line 303 in power_grid_model_c/power_grid_model/include/power_grid_model/main_core/update.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"std::forward" is never called on this forwarding reference argument. 

See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AZ47UwT7zbV7Z3PiMmfa&open=AZ47UwT7zbV7Z3PiMmfa&pullRequest=1401

Check failure on line 51 in power_grid_model_c/power_grid_model/include/power_grid_model/common/grouped_index_vector.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"std::forward" is never called on this forwarding reference argument. 

See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AZ47UwUVzbV7Z3PiMmfd&open=AZ47UwUVzbV7Z3PiMmfd&pullRequest=1401

Check failure on line 61 in power_grid_model_c/power_grid_model/include/power_grid_model/job_interface.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"std::forward" is never called on this forwarding reference argument. 

See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AZ47UwWHzbV7Z3PiMmfl&open=AZ47UwWHzbV7Z3PiMmfl&pullRequest=1401

Check failure on line 189 in power_grid_model_c/power_grid_model/include/power_grid_model/main_core/update.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"std::forward" is never called on this forwarding reference argument. 

See more on https://sonarcloud.io/project/issues?id=PowerGridModel_power-grid-model&issues=AZ47UwT6zbV7Z3PiMmfW&open=AZ47UwT6zbV7Z3PiMmfW&pullRequest=1401
View more details on SonarQubeCloud