Draft
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1476d7d. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Harness.agent_patch_state_key/ComposableEnvgit helpers with a genericHarness.state_collectorslifecycle hookGitPatchCollector, which snapshots the post-setup worktree with git tree plumbing through a temporary index and stores the post-rollout diff instate["agent_patch"]rlm_harness()to useGitPatchCollector()soresearch-environments2'srlm_swecomposition gets patch capture without duplicating SWE taskset or RLM harness internalsNotes
Tests
uv run pytest tests/test_composable_env.py tests/test_rlm_composable_env.py -quv run ruff check verifiers/envs/experimental/composable/composable_env.py verifiers/envs/experimental/composable/harness.py verifiers/envs/experimental/composable/harnesses/rlm.py verifiers/envs/experimental/composable/state_collectors.py tests/test_composable_env.py tests/test_rlm_composable_env.pyuv run ruff format --check verifiers/envs/experimental/composable/composable_env.py verifiers/envs/experimental/composable/harness.py verifiers/envs/experimental/composable/harnesses/rlm.py verifiers/envs/experimental/composable/state_collectors.py tests/test_composable_env.py tests/test_rlm_composable_env.pyruff check,ruff format,Sync AGENTS.md from docs,ty (ci parity)Note
Medium Risk
Adds new lifecycle hooks that execute extra sandbox commands during setup/rollout, which can affect timing and state mutation if collectors misbehave (though failures are logged and ignored). Git-based patch collection depends on repo state and tool availability inside the sandbox, so it may introduce intermittent missing/empty artifacts.
Overview
Adds harness-owned state collectors to
ComposableEnv, running optionalpost_sandbox_setupandpost_rollouthooks to persist rollout artifacts intostatewhile swallowing collector failures.Introduces
GitPatchCollector, which snapshots a post-setup git tree using a temporary index and then stores a binary/full-index diff of agent edits intostate["agent_patch"]after rollout. Enables this collector by default inrlm_harness, exports it fromverifiers.envs.experimental.composable, and updates docs/tests to cover collector execution and patch correctness (including untracked/staged changes without modifyingHEAD).Reviewed by Cursor Bugbot for commit cb12ae9. Bugbot is set up for automated code reviews on this repo. Configure here.