Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes Nemotron3 prompt rendering semantics for
reasoning_contentby introducing aclear_thinkingflag and a new registry entry to keep historical thinking, which can alter tokenization/training masks and downstream model behavior for Nemotron3 runs.Overview
Adds a
clear_thinkingoption toNemotron3Rendererthat controls whetherreasoning_contentin earlier assistant turns is collapsed to an empty<think></think>block or preserved, updating the assistant rendering path accordingly.Registers a new
nemotron3_keep_thinkingrenderer variant (subclassingNemotron3Rendererwithclear_thinking=False) inrenderers/base.pyso callers can opt into keeping thinking content across the full conversation history.Reviewed by Cursor Bugbot for commit 12a9fd3. Bugbot is set up for automated code reviews on this repo. Configure here.