Skip to content

Updated to work with 5.3.5 #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ilsonb wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Updated to work with 5.3.5 #109

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ee7e42c
Fix ReVanced patches for new CLI and Gradle plugins
Mar 17, 2026
a6a5a5a
Fix ClassCastException in Telemetry Patch
Mar 17, 2026
30ef732
Strip split APK metadata constraints in patch
Mar 17, 2026
5893f55
Bypass PairIP License Check from AndroidManifest
Mar 17, 2026
44d7a56
Fix PR Feedback from CodeRabbit AI
Mar 17, 2026
fb49852
Address remaining PR Feedback: curl fail-fast, Bash arrays, patch sco…
Mar 17, 2026
fd58e54
Address additional PR Feedback: Clarify SHA-256 logging and fix patch…
Mar 17, 2026
e9d44b5
Address final PR feedback: Fix script build paths and remove missing …
Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ GameHub Lite is a community-maintained modified version of GameHub for education

## GameHub Lite Patcher

A patching system that transforms GameHub 5.1.0 into GameHub Lite. A privacy-focused, lightweight version with telemetry removed and offline support added.
A patching system that transforms GameHub 5.3.5 into GameHub Lite. A privacy-focused, lightweight version with telemetry removed and offline support added.

## What is GameHub Lite?

Expand Down Expand Up @@ -55,7 +55,7 @@ stop using windows

### Patching

1. Download GameHub 5.1.0 APK and place it at `apk/GameHub-5.1.0.apk`
1. Download GameHub 5.3.5 APK and place it at `apk/GameHub-5.3.5.apk`

2. Run the patcher:

Expand Down Expand Up @@ -216,7 +216,7 @@ patches/

If patches fail due to APK version mismatch:

- Ensure you're using GameHub 5.1.0 exactly
- Ensure you're using GameHub 5.3.5 exactly
- Check the MD5 hash matches expected value
- Try regenerating patches with your APK version

Expand All @@ -235,8 +235,8 @@ If patches fail due to APK version mismatch:

| GameHub Version | Patcher Version | Status |
| --------------- | --------------- | -------------- |
| 5.1.0 | 1.0 | Supported |
| 5.3.3 | - | in development |
| 5.1.0 | 1.0 | Deprecated |
| 5.3.5 | 1.0 | Supported |

## Alternative: ReVanced Patches (WORK IN PROGRESS)

Expand All @@ -245,7 +245,7 @@ This doesn't currently support all features of the Lite APK, but you are free to

```bash
cd revanced
./apply-patches.sh ../apk/GameHub-5.1.0.apk
./apply-patches.sh ../apk/GameHub-5.3.5.apk
```

See [revanced/README.md](revanced/README.md) for details.
Expand Down
2 changes: 1 addition & 1 deletion generate-patches.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
DECOMPILED_DIR="$SCRIPT_DIR/decompiled"
PATCHES_DIR="$SCRIPT_DIR/patches"

ORIGINAL_APK="${1:-$SCRIPT_DIR/apk/GameHub-5.1.0.apk}"
ORIGINAL_APK="${1:-$SCRIPT_DIR/apk/GameHub-5.3.5.apk}"
LITE_APK="${2:-$SCRIPT_DIR/apk/GameHub-Lite.apk}"

print_step() {
Expand Down
35 changes: 18 additions & 17 deletions patch.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash
#
# GameHub Lite Patcher
# Applies patches to GameHub 5.1.0 APK to create GameHub Lite
# Applies patches to GameHub 5.3.5 APK to create GameHub Lite
#

set -e
Expand Down Expand Up @@ -52,7 +52,7 @@ get_variant_package() {
}

# Source APK (can be overridden)
SOURCE_APK="${1:-$SCRIPT_DIR/apk/GameHub-5.1.0.apk}"
SOURCE_APK="${1:-$SCRIPT_DIR/apk/GameHub-5.3.5.apk}"
OUTPUT_APK="$OUTPUT_DIR/GameHub-Lite.apk"

print_step() {
Expand All @@ -78,7 +78,7 @@ extract_version() {
VERSION=$(grep "versionName:" "$WORK_DIR/decompiled/apktool.yml" | head -1 | awk -F': ' '{print $2}' | tr -d "'" | tr -d ' ')
fi
# Default fallback
VERSION="${VERSION:-5.1.0}"
VERSION="${VERSION:-5.3.5}"
print_success "Version: $VERSION"
}

Expand Down Expand Up @@ -171,34 +171,35 @@ verify_source_apk() {
if [ ! -f "$SOURCE_APK" ]; then
print_error "Source APK not found: $SOURCE_APK"
echo ""
echo "Please provide GameHub 5.1.0 APK as first argument or place it at:"
echo " $SCRIPT_DIR/apk/GameHub-5.1.0.apk"
echo "Please provide GameHub 5.3.5 APK as first argument or place it at:"
echo " $SCRIPT_DIR/apk/GameHub-5.3.5.apk"
exit 1
fi

# Calculate MD5 of source APK
local md5
if command -v md5sum &>/dev/null; then
md5=$(md5sum "$SOURCE_APK" | awk '{print $1}')
# Calculate SHA-256 of source APK
local sha256
if command -v sha256sum &>/dev/null; then
sha256=$(sha256sum "$SOURCE_APK" | awk '{print $1}')
else
md5=$(md5 -q "$SOURCE_APK")
sha256=$(shasum -a 256 "$SOURCE_APK" | awk '{print $1}')
fi

# Expected MD5 for GameHub 5.1.0
local expected_md5="42db81116bf3c74e52e6f6afb4ec9f91" # Replace with actual MD5 if you are intentionally using a different APK
# Expected SHA-256 for GameHub 5.3.5 (set via env for flexibility)
local expected_sha256="${EXPECTED_SHA256:-}"

print_success "Source APK found: $(basename "$SOURCE_APK")"
echo " MD5: $md5"
if [ "$md5" != "$expected_md5" ]; then
print_warning "MD5 checksum does not match expected value."
echo " SHA-256: $sha256"

if [ -n "$expected_sha256" ] && [ "$sha256" != "$expected_sha256" ]; then
print_warning "SHA-256 checksum does not match expected value."
print_warning "Proceeding may lead to unexpected results."
read -pr "Do you want to continue? (y/N): " choice
read -r -p "Do you want to continue? (y/N): " choice
if [[ ! "$choice" =~ ^[Yy]$ ]]; then
print_error "Aborting."
exit 1
fi
else
print_success "MD5 checksum verified."
print_success "SHA-256 checksum verified (or no restriction set)."

@coderabbitai coderabbitai Bot Mar 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Demonstrate that a missing command in a pipeline still yields an empty value without pipefail.
bash -lc 'set -e; value=$(missing_hash_tool 2>/dev/null | awk "{print \$1}"); printf "pipeline_value=<%s>\n" "$value"'

# Inspect the checksum logic in patch.sh.
rg -n 'set -e|set -o pipefail|sha256sum|shasum|EXPECTED_SHA256|SHA-256 checksum verified' patch.sh
sed -n '168,205p' patch.sh

Repository: Producdevity/gamehub-lite

Length of output: 1806

Clarify the SHA-256 verification success message to distinguish between "verified" and "skipped" states.

The success message at line 202 conflates two scenarios: when verification passes and when it's skipped. When EXPECTED_SHA256 is unset, printing "SHA-256 checksum verified (or no restriction set)" is misleading—the checksum was computed but verification was intentionally skipped, not verified. Split the messages to be explicit: print "SHA-256 checksum verified." when the hash matches an expected value, and print a warning when verification is skipped.

The suggested fix also improves code clarity by explicitly checking both checksum tools upfront rather than using a silent fallback:

🔧 Suggested fix 
-    local sha256
-    if command -v sha256sum &>/dev/null; then
-        sha256=$(sha256sum "$SOURCE_APK" | awk '{print $1}')
-    else
-        sha256=$(shasum -a 256 "$SOURCE_APK" | awk '{print $1}')
-    fi
+    local sha256
+    local -a sha256_cmd
+    if command -v sha256sum &>/dev/null; then
+        sha256_cmd=(sha256sum)
+    elif command -v shasum &>/dev/null; then
+        sha256_cmd=(shasum -a 256)
+    else
+        print_error "Neither sha256sum nor shasum is available."
+        exit 1
+    fi
+    sha256=$("${sha256_cmd[@]}" "$SOURCE_APK" | awk '{print $1}')
@@
-    else
-        print_success "SHA-256 checksum verified (or no restriction set)."
+    elif [ -n "$expected_sha256" ]; then
+        print_success "SHA-256 checksum verified."
+    else
+        print_warning "SHA-256 verification skipped; EXPECTED_SHA256 is not set."
     fi
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Calculate SHA-256 of source APK
local sha256
if command -v sha256sum &>/dev/null; then
sha256=$(sha256sum "$SOURCE_APK" | awk '{print $1}')
else
md5=$(md5 -q "$SOURCE_APK")
sha256=$(shasum -a 256 "$SOURCE_APK" | awk '{print $1}')
fi
# Expected MD5 for GameHub 5.1.0
local expected_md5="42db81116bf3c74e52e6f6afb4ec9f91" # Replace with actual MD5 if you are intentionally using a different APK
# Expected SHA-256 for GameHub 5.3.5 (set via env for flexibility)
local expected_sha256="${EXPECTED_SHA256:-}"
print_success "Source APK found: $(basename "$SOURCE_APK")"
echo " MD5: $md5"
if [ "$md5" != "$expected_md5" ]; then
print_warning "MD5 checksum does not match expected value."
echo " SHA-256: $sha256"
if [ -n "$expected_sha256" ] && [ "$sha256" != "$expected_sha256" ]; then
print_warning "SHA-256 checksum does not match expected value."
print_warning "Proceeding may lead to unexpected results."
read -pr "Do you want to continue? (y/N): " choice
read -r -p "Do you want to continue? (y/N): " choice
if [[ ! "$choice" =~ ^[Yy]$ ]]; then
print_error "Aborting."
exit 1
fi
else
print_success "MD5 checksum verified."
print_success "SHA-256 checksum verified (or no restriction set)."
# Calculate SHA-256 of source APK
local sha256
local -a sha256_cmd
if command -v sha256sum &>/dev/null; then
sha256_cmd=(sha256sum)
elif command -v shasum &>/dev/null; then
sha256_cmd=(shasum -a 256)
else
print_error "Neither sha256sum nor shasum is available."
exit 1
fi
sha256=$("${sha256_cmd[@]}" "$SOURCE_APK" | awk '{print $1}')
# Expected SHA-256 for GameHub 5.3.5 (set via env for flexibility)
local expected_sha256="${EXPECTED_SHA256:-}"
print_success "Source APK found: $(basename "$SOURCE_APK")"
echo " SHA-256: $sha256"
if [ -n "$expected_sha256" ] && [ "$sha256" != "$expected_sha256" ]; then
print_warning "SHA-256 checksum does not match expected value."
print_warning "Proceeding may lead to unexpected results."
read -r -p "Do you want to continue? (y/N): " choice
if [[ ! "$choice" =~ ^[Yy]$ ]]; then
print_error "Aborting."
exit 1
fi
elif [ -n "$expected_sha256" ]; then
print_success "SHA-256 checksum verified."
else
print_warning "SHA-256 verification skipped; EXPECTED_SHA256 is not set."
fi
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@patch.sh` around lines 179 - 202, The SHA-256 message currently conflates
“verified” and “skipped”; update the logic that uses SOURCE_APK, EXPECTED_SHA256
and sha256 so that if EXPECTED_SHA256 is set and matches you call print_success
"SHA-256 checksum verified.", if EXPECTED_SHA256 is unset you call print_warning
"SHA-256 verification skipped (no EXPECTED_SHA256 set).", and keep the existing
warning/abort flow when it is set and mismatches; also check availability of
checksum tools (sha256sum or shasum) up front and fail with a clear error via
print_error if neither is present instead of silently falling back.

fi
}

Expand Down
6 changes: 2 additions & 4 deletions patches/diffs/apktool.yml.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,8 @@
@@ -10,16 +10,14 @@
forcedPackageId: 127
versionInfo:
- versionCode: 60
+ versionCode: 61
- versionName: 5.1.0
+ versionName: 5.1.4
versionCode: 60
versionName: 5.3.5
doNotCompress:
- arsc
- gif
Expand Down
12 changes: 6 additions & 6 deletions revanced/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ This is an **alternative** to the diff-based patching system in the parent direc

```bash
# Using the helper script
./apply-patches.sh path/to/GameHub-5.1.0.apk
./apply-patches.sh path/to/GameHub-5.3.5.apk

# With custom output
./apply-patches.sh GameHub-5.1.0.apk -o GameHub-Lite.apk
./apply-patches.sh GameHub-5.3.5.apk -o GameHub-Lite.apk

# List available patches
./apply-patches.sh -l
Expand All @@ -66,7 +66,7 @@ This is an **alternative** to the diff-based patching system in the parent direc
java -jar tools/revanced-cli.jar patch \
--patch-bundle build/libs/gamehub-lite-patches.jar \
--out GameHub-Lite.apk \
GameHub-5.1.0.apk
GameHub-5.3.5.apk
```

### Using ReVanced Manager
Expand Down Expand Up @@ -137,7 +137,7 @@ revanced/
name = "My Patch",
description = "Does something useful",
) {
compatibleWith("com.xiaoji.egggame"("5.1.0"))
compatibleWith("com.xiaoji.egggame"("5.3.5"))

execute {
myFingerprint.method.addInstructions(0, "return-void")
Expand All @@ -149,7 +149,7 @@ revanced/

```bash
# Build and apply in one step
./gradlew build && ./apply-patches.sh ../apk/GameHub-5.1.0.apk
./gradlew build && ./apply-patches.sh ../apk/GameHub-5.3.5.apk

# Install on device
adb install output/GameHub-Lite.apk
Expand Down Expand Up @@ -201,7 +201,7 @@ gpr.key=ghp_xxxxxxxxxxxx
Ensure the fingerprint matches the target method. Use jadx to inspect the APK:

```bash
jadx GameHub-5.1.0.apk -d jadx-output
jadx GameHub-5.3.5.apk -d jadx-output
```

### APK Won't Install
Expand Down
30 changes: 14 additions & 16 deletions revanced/apply-patches.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
#!/bin/bash
#
# GameHub Lite - ReVanced Patch Applier
# Applies ReVanced patches to GameHub 5.1.0 APK
# Applies ReVanced patches to GameHub 5.3.5 APK
#

set -e

SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
PATCHES_JAR="$SCRIPT_DIR/build/libs/gamehub-lite-patches.jar"
PATCHES_JAR="$SCRIPT_DIR/patches/build/libs/patches.rvp"
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
CLI_JAR="$SCRIPT_DIR/tools/revanced-cli.jar"
OUTPUT_DIR="$SCRIPT_DIR/output"

Expand Down Expand Up @@ -44,9 +44,9 @@ show_usage() {
echo " -h, --help Show this help message"
echo ""
echo "Examples:"
echo " $0 GameHub-5.1.0.apk"
echo " $0 GameHub-5.1.0.apk -o my-output.apk"
echo " $0 GameHub-5.1.0.apk -p \"Disable All Telemetry,GameHub Lite\""
echo " $0 GameHub-5.3.5.apk"
echo " $0 GameHub-5.3.5.apk -o my-output.apk"
echo " $0 GameHub-5.3.5.apk -p \"Disable All Telemetry,GameHub Lite\""
}

check_dependencies() {
Expand Down Expand Up @@ -75,12 +75,12 @@ download_cli() {
mkdir -p "$SCRIPT_DIR/tools"

# Get latest ReVanced CLI release
local cli_url="https://github.com/ReVanced/revanced-cli/releases/latest/download/revanced-cli-all.jar"
local cli_url="https://github.com/ReVanced/revanced-cli/releases/download/v5.0.1/revanced-cli-5.0.1-all.jar"

print_step "Downloading ReVanced CLI..."
curl -L -o "$CLI_JAR" "$cli_url"
curl -fL --retry 3 --connect-timeout 15 -o "$CLI_JAR" "$cli_url"

if [ -f "$CLI_JAR" ]; then
if [ -s "$CLI_JAR" ]; then
print_success "ReVanced CLI downloaded"
else
print_error "Failed to download ReVanced CLI"
Expand All @@ -94,7 +94,7 @@ build_patches() {
cd "$SCRIPT_DIR"

if [ -f "gradlew" ]; then
./gradlew build
./gradlew apiDump build jar
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
else
print_error "Gradle wrapper not found. Run 'gradle wrapper' first"
exit 1
Expand All @@ -112,7 +112,7 @@ list_patches() {
print_step "Available patches:"

java -jar "$CLI_JAR" list-patches \
--patch-bundle "$PATCHES_JAR"
-p "$PATCHES_JAR"
}

apply_patches() {
Expand All @@ -129,21 +129,19 @@ apply_patches() {

print_step "Applying patches to $(basename "$input_apk")..."

local cmd="java -jar $CLI_JAR patch"
cmd="$cmd --patch-bundle $PATCHES_JAR"
cmd="$cmd --out $output_apk"
local cmd=(java -jar "$CLI_JAR" patch -p "$PATCHES_JAR" -o "$output_apk")

if [ -n "$patch_list" ]; then
# Apply specific patches
IFS=',' read -ra PATCHES <<< "$patch_list"
for patch in "${PATCHES[@]}"; do
cmd="$cmd --include \"$patch\""
cmd+=(-e "$patch")
done
fi

cmd="$cmd $input_apk"
cmd+=("$input_apk")

eval "$cmd"
"${cmd[@]}"

if [ -f "$output_apk" ]; then
print_success "Patched APK created: $output_apk"
Expand Down
Binary file added revanced/gradle/wrapper/gradle-wrapper.jar
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion revanced/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.5-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.4.0-bin.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
Expand Down
Loading