Fix "Don Thousand/Spell A"#1266
Open
botist wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don Thousand/Spell Acurrently retains the Spell/Trap sent for its cost withDuel.SetTargetCard. This adds that card to the current chain's target group. When the copied operation later callsDuel.GetFirstTarget(), it can receive the sent card in the Graveyard instead of the target selected by the copied effect. As a result, costs are paid but effects such asRaigeki BreakandTribute to The Doomedfail to destroy their target.This change stores each sent card separately using the activation's unique chain ID. It does not overwrite label state used by copied effects, supports multiple activations in the same chain, and leaves the target group available exclusively to the copied effect.
The target-relation handling now also permits an absent target group, preserving the intended Boss Duel interaction with the no-target
Don Thousand/Spell B(Numeron Calling) effect.Verified with Project Ignis ScriptChecker v1.5 using the current
ProjectIgnis/binocgcore. Targeted regressions covered both a cost-plus-target destruction-style effect and the original no-target Boss Duel effect.