Backfill now replays first approvals for GitHub PR triggers - #862
Open
promptless[bot] wants to merge 2 commits into
Open
Backfill now replays first approvals for GitHub PR triggers#862promptless[bot] wants to merge 2 commits into
promptless[bot] wants to merge 2 commits into
Conversation
…iggers Corrects the Backfill suggestions section: a GitHub PR trigger set to first_approval can now be backfilled (open PRs whose first approval landed within the selected window). Reflects Promptless/promptless#2837. GitLab MR and Bitbucket PR triggers still don't replay approvals.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Promptless/promptless#2837 (merged 922f2a1) makes backfill replay first approvals for first-approval-only GitHub PR triggers. Add the August 2026 changelog entry, tighten the triggers backfill paragraph (GitLab/Bitbucket have no first-approval option), and refresh the month subtitle.
promptless
Bot
requested review from
adit-chandra,
frances720,
hawkeyexl and
mattlink
as code owners
August 15, 2026 00:45
![promptless[bot]](https://avatars.githubusercontent.com/in/979718?s=60&v=4){kind=small}
| Open the **Backfill suggestions** panel on a trigger row, choose a window of the **last 14 days**, **last 30 days**, or **last 90 days**, and select **Preview**. The preview lists the pull requests opened or merged in that window that the trigger matches, applying the same repository, topic, directory, and branch filters it uses for live events. When a trigger scopes repositories by GitHub topic (the **Trigger on repos with certain topics** option, covered in [Repository topics](/docs/connect/triggers/github-prs#repository-topics)), the preview lists pull requests only from repositories that carry a matching topic. Backfill covers up to 1,000 pull requests per repository in the window. | ||
|
|
||
| Backfill matches pull requests that were opened or merged but it doesn't replay historical approvals. A trigger that activates only on first approval returns no backfill results because approval matching applies only to live events going forward. | ||
| Backfill also replays first approvals for GitHub PR triggers that activate only on first approval: the preview includes open pull requests whose first approval landed within the selected window, even if they were opened before the window. GitLab merge request and Bitbucket PR triggers don't offer a first-approval option, so this backfill behavior applies only to GitHub. |
Contributor
Author
There was a problem hiding this comment.
list_matching_pull_requests docstring: backfill now replays approval-shaped events for GitHub PR triggers with a first_approval-only clause, matching PRs whose first active approval landed in the window even if opened long before it.
| Open the **Backfill suggestions** panel on a trigger row, choose a window of the **last 14 days**, **last 30 days**, or **last 90 days**, and select **Preview**. The preview lists the pull requests opened or merged in that window that the trigger matches, applying the same repository, topic, directory, and branch filters it uses for live events. When a trigger scopes repositories by GitHub topic (the **Trigger on repos with certain topics** option, covered in [Repository topics](/docs/connect/triggers/github-prs#repository-topics)), the preview lists pull requests only from repositories that carry a matching topic. Backfill covers up to 1,000 pull requests per repository in the window. | ||
|
|
||
| Backfill matches pull requests that were opened or merged but it doesn't replay historical approvals. A trigger that activates only on first approval returns no backfill results because approval matching applies only to live events going forward. | ||
| Backfill also replays first approvals for GitHub PR triggers that activate only on first approval: the preview includes open pull requests whose first approval landed within the selected window, even if they were opened before the window. GitLab merge request and Bitbucket PR triggers don't offer a first-approval option, so this backfill behavior applies only to GitHub. |
Contributor
Author
There was a problem hiding this comment.
_recent_pull_request_search_queries: approval-mode search stays is:open but widens the date filter from created:>= to updated:>=, so PRs opened before the backfill window are included when their approval landed inside it.
| Open the **Backfill suggestions** panel on a trigger row, choose a window of the **last 14 days**, **last 30 days**, or **last 90 days**, and select **Preview**. The preview lists the pull requests opened or merged in that window that the trigger matches, applying the same repository, topic, directory, and branch filters it uses for live events. When a trigger scopes repositories by GitHub topic (the **Trigger on repos with certain topics** option, covered in [Repository topics](/docs/connect/triggers/github-prs#repository-topics)), the preview lists pull requests only from repositories that carry a matching topic. Backfill covers up to 1,000 pull requests per repository in the window. | ||
|
|
||
| Backfill matches pull requests that were opened or merged but it doesn't replay historical approvals. A trigger that activates only on first approval returns no backfill results because approval matching applies only to live events going forward. | ||
| Backfill also replays first approvals for GitHub PR triggers that activate only on first approval: the preview includes open pull requests whose first approval landed within the selected window, even if they were opened before the window. GitLab merge request and Bitbucket PR triggers don't offer a first-approval option, so this backfill behavior applies only to GitHub. |
Contributor
Author
There was a problem hiding this comment.
MergeRequestLifecycleEvent (GitLab MR / Bitbucket PR triggers) is Literal["opened", "merge"] and explicitly excludes first_approval, because the webhook lifecycle mapper never emits it for those providers -- confirms GitLab/Bitbucket first-approval triggers have no backfill analogue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open in Promptless
Corrects the "Backfill suggestions" section of the triggers overview page and adds the August 2026 changelog entry. The page previously stated that a GitHub PR trigger configured only for first approval "returns no backfill results." Promptless/promptless#2837 makes that false: backfill now replays first approvals for GitHub PR triggers that activate only on first approval, including open pull requests whose first approval landed within the selected window even if they were opened before it. The correction states that GitLab merge request and Bitbucket PR triggers have no first-approval option, so this backfill behavior applies only to GitHub.
✅ Deferral resolved — ready for review. Promptless/promptless#2837 merged into
mainon 2026-08-15 at commit922f2a1fe0bfd05d7dbfa6a676e1d35d7212f7e4. The three pre-merge follow-ups this change was held for are now complete:922f2a1).created:>=→updated:>=widening; GitLab/Bitbucket have no first-approval option).mainSHA (runtime/replays/service.py,runtime/replays/git_sources/github.py,runtime/promptless_config/models.py).Trigger Events