Add test showcasing external signing for multiple requests for a single transaction#1330
Draft
vicsn wants to merge 6 commits into
Draft
Add test showcasing external signing for multiple requests for a single transaction#1330vicsn wants to merge 6 commits into
vicsn wants to merge 6 commits into
Conversation
5 tasks
iamalwaysuncomfortable
changed the base branch from
mainnet
to
test/canary-v4.5.4-compat
iamalwaysuncomfortable
changed the base branch from
test/canary-v4.5.4-compat
to
mainnet
iamalwaysuncomfortable
left a comment
iamalwaysuncomfortable
left a comment
Member
There was a problem hiding this comment.
This deserves a discussion before this lands. There's a lot of open questions about the pipeline of sampling to --> consuming requests into a proof.
I assume some of those questions might be answered by examining the SnarkVM rev in this PR?
iamalwaysuncomfortable
force-pushed
the
add_nested_signing_test
branch
from
6b34141 to
abd6272
Compare
Widen ProvingRequestOptions.executionRequest to ExecutionRequest | ExecutionRequest[] (renamed from the plural executionRequests) and normalize to an array inside provingRequest() so callers can pass one request or many. Update the test to pass a single request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The high level workflow:
sampleAuthorizationsamples inputs for the full call graphcomputeExternalSigningInputsis called for every requestfromExternallySignedDataWithViewKeyis called for every requestbuildProvingRequestFromExecutionRequestprepares a submission to the delegated prover.