Skip to content

Strengthen Note HTML smoke assertions #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kiki830621 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Strengthen Note HTML smoke assertions #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions Tests/MacDocCLITests/NoteHTMLConvertTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,32 @@ final class NoteHTMLConvertTests: XCTestCase {
"output SHALL include index.html"
)

let mediaURL = outputDir.appendingPathComponent("media", isDirectory: true)
var mediaIsDirectory: ObjCBool = false
XCTAssertTrue(
FileManager.default.fileExists(atPath: mediaURL.path, isDirectory: &mediaIsDirectory),
"output SHALL include media/ for rendered note assets"
)
XCTAssertTrue(mediaIsDirectory.boolValue, "media/ SHALL be a directory")

let mediaFiles = try FileManager.default.contentsOfDirectory(
at: mediaURL,
includingPropertiesForKeys: nil
).filter { !$0.hasDirectoryPath }
XCTAssertGreaterThanOrEqual(
mediaFiles.count, 1,
"media/ SHALL contain at least one stroke, image, or audio asset"
)

let indexData = try Data(contentsOf: indexURL)
// Baseline 2026-05-02 using `test-files/筆記 2026-03-20 15_25_20.note`:
// 1,569,860 bytes. The 750 KB floor catches empty-shell regressions
// while leaving headroom for renderer/template changes.
XCTAssertGreaterThan(
indexData.count, 750_000,
"index.html SHALL be a non-trivial rendered player, not a tiny shell"
)

let content = try String(contentsOf: indexURL, encoding: .utf8)
XCTAssertGreaterThan(content.count, 0, "index.html SHALL be non-empty")
XCTAssertTrue(
Expand Down
Loading