Conversation
|
@Ivenkili Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Kindly fix CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement per-principal rate limiting across the backend to ensure authenticated clients are isolated from one another and expensive endpoints receive appropriately stricter limits.
Currently, rate limits are not consistently scoped to the authenticated principal, allowing one authenticated client to consume a shared budget associated with the source address. This change introduces principal-aware keys while preserving source-address fallback for unauthenticated requests.
Changes Made
Updated rate-limit key generation to use the authenticated principal when available.
Added source-address fallback for requests without an authenticated principal.
Added separate, stricter rate limits for expensive endpoint classes:
Added standard rate-limit response headers.
Added
Retry-Afterheaders for rejected requests.Added separately configurable rate limits for bot and service principals authenticated through
bot-auth.Added rate-limit rejection metrics labelled by endpoint class.
Added tests covering principal isolation, endpoint-specific limits, headers, bot/service limits, and rejection metrics.
Acceptance Criteria
Retry-Aftervalue.Testing
Retry-Afteron rate-limit rejection.Files / Areas
apps/backend/src/common/rate-limit/Closes #1205