fix: add tiered rate limiting across remaining public endpoints - #958
Open
doctorlight0 wants to merge 30 commits into
Open
doctorlight0 wants to merge 30 commits into
doctorlight0 wants to merge 30 commits into
Conversation
|
@doctorlight0 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR extends the existing throttler into named rate limit tiers applied across the public surface. Discovery, username lookup, profile reads, marketplace queries, and export requests now each have an explicit tier, preventing cheap enumeration attacks. Limits are configurable, key on API key when present, fall back to client identity otherwise, and return a consistent error body with a retry hint when exceeded.
Related Issue
Closes #BE-116
Changes
🛡️ Tiered Rate Limiting
[ADD]
app/backend/src/common/constants/rate-limit.constants.tspublic-read,search,mutation, andexport.[ADD]
app/backend/src/auth/decorators/rate-limit-group.decorator.ts@RateLimitGroup(tier)decorator to assign a named tier to any public route.[MODIFY]
app/backend/src/auth/guards/custom-throttler.guard.ts@RateLimitGroup, defaulting topublic-readfor unassigned routes.429error body withretryAfterhint on exceeded limits.[MODIFY]
app/backend/src/app.module.ts[MODIFY]
app/backend/src/exports/exports.controller.tsexporttier to export request endpoints.[ADD]
app/backend/src/auth/guards/custom-throttler.guard.unit.spec.tsVerification Results
public-read,search,mutation,exportimplemented with configurable limitscustom-throttler.guard.unit.spec.ts429response includesretryAfterand stable error messageCloses #815