Skip to content

updating <details> to <Accordion> and remove pre-course survey#4927

Open
0sophy1 wants to merge 18 commits intomainfrom
sy/4913-maintenance
Open

updating <details> to <Accordion> and remove pre-course survey#4927
0sophy1 wants to merge 18 commits intomainfrom
sy/4913-maintenance

Conversation

@0sophy1
Copy link
Copy Markdown
Member

@0sophy1 0sophy1 commented Apr 2, 2026

Fixes #[4913]

This PR converts all <details>/<summary> HTML tags to <Accordion>/<AccordionItem> components in learning contents and removed pre-course surveys

@0sophy1 0sophy1 requested a review from a team April 2, 2026 02:14
@0sophy1 0sophy1 linked an issue Apr 2, 2026 that may be closed by this pull request
37 tasks
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@qiskit-bot
Copy link
Copy Markdown
Contributor

One or more of the following people are relevant to this code:

"\n",
"</summary>\n",
"<Accordion>\n",
"<AccordionItem title=\"How many qubits are in the circuit below? ![A circuit diagram with four horizontal lines and many gates.](/learning/images/courses/integrating-quantum-and-high-performance-computing/programming-models/checkin-circuit.svg)\">\n",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0sophy1 a link (even to an image) will not render in the accordion - I suggest either putting the image directly below the accordion, or directly above (and change the language to "how many qubits are in the circuit above?")

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Abby, thanks for the heads‑up. I saw that the preview can render the image in the title, so I thought we could use it there.

0sophy1 and others added 3 commits April 2, 2026 09:32
…uting/compute-resources.ipynb

Co-authored-by: abbycross <across@us.ibm.com>
…uting/compute-resources.ipynb

Co-authored-by: abbycross <across@us.ibm.com>
…uting/compute-resources.ipynb

Co-authored-by: abbycross <across@us.ibm.com>
0sophy1 and others added 3 commits April 2, 2026 09:36
…g-fundamentals.mdx

Co-authored-by: abbycross <across@us.ibm.com>
…g-fundamentals.mdx

Co-authored-by: abbycross <across@us.ibm.com>
0sophy1 and others added 2 commits April 2, 2026 09:41
"\n",
"</summary>\n",
"<Accordion>\n",
"<AccordionItem title=\"Please use [Coulomb law](https://en.wikipedia.org/wiki/Coulomb%27s_law) and [atomic unit](https://en.wikipedia.org/wiki/Atomic_units) to make sure you get the value in `Hartree`.\">\n",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links will need to be removed. Maybe include them under the image instead?

@abbycross
Copy link
Copy Markdown
Collaborator

great work, thanks @0sophy1! One thing I noticed that maybe you and @christopherporter1 can decide which one you like better: When there are several questions one after the other, the spacing between them renders differently depending on whether you group all of them within the same Accordion component, or whether they each get their own Accordion. To demonstrate what I mean - the first image is where they are inside the same component, and the second is one where they each have their own.
Screenshot 2026-04-02 at 12 31 49 PM
Screenshot 2026-04-02 at 12 31 56 PM

It's up to you stylistically which you like better, and then we should be consistent throughout. We also want to avoid mixing both, like what happened in this one:
Screenshot 2026-04-02 at 1 00 38 PM

@abbycross
Copy link
Copy Markdown
Collaborator

abbycross commented Apr 2, 2026

One last comment: I noticed that the <br> tags were sometimes put to use and seem work nicely inside the titles, so I suggest going through the questions that contain many parts (usually they are listed as (a), (b), etc.) and use the
to format them nicely, when they are just in a big block.

0sophy1 and others added 4 commits April 2, 2026 13:35
Co-authored-by: abbycross <across@us.ibm.com>
Co-authored-by: abbycross <across@us.ibm.com>
…qiskit.ipynb

Co-authored-by: abbycross <across@us.ibm.com>
@0sophy1
Copy link
Copy Markdown
Member Author

0sophy1 commented Apr 2, 2026

great work, thanks @0sophy1! One thing I noticed that maybe you and @christopherporter1 can decide which one you like better: When there are several questions one after the other, the spacing between them renders differently depending on whether you group all of them within the same Accordion component, or whether they each get their own Accordion. To demonstrate what I mean - the first image is where they are inside the same component, and the second is one where they each have their own. Screenshot 2026-04-02 at 12 31 49 PM Screenshot 2026-04-02 at 12 31 56 PM

It's up to you stylistically which you like better, and then we should be consistent throughout. We also want to avoid mixing both, like what happened in this one: Screenshot 2026-04-02 at 1 00 38 PM

great work, thanks @0sophy1! One thing I noticed that maybe you and @christopherporter1 can decide which one you like better: When there are several questions one after the other, the spacing between them renders differently depending on whether you group all of them within the same Accordion component, or whether they each get their own Accordion. To demonstrate what I mean - the first image is where they are inside the same component, and the second is one where they each have their own. Screenshot 2026-04-02 at 12 31 49 PM Screenshot 2026-04-02 at 12 31 56 PM

It's up to you stylistically which you like better, and then we should be consistent throughout. We also want to avoid mixing both, like what happened in this one: Screenshot 2026-04-02 at 1 00 38 PM

Hi Abby, I did my best to edit everything into a more unified style (similar to the first option). I’m sorry if I missed anything. Personally, I prefer the first style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Update learning content components - maintenance

3 participants