updating <details> to <Accordion> and remove pre-course survey#4927
updating <details> to <Accordion> and remove pre-course survey#4927
Conversation
- use Accordion - fix minor issues
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
One or more of the following people are relevant to this code: |
learning/courses/integrating-quantum-and-high-performance-computing/compute-resources.ipynb
Outdated
Show resolved
Hide resolved
learning/courses/integrating-quantum-and-high-performance-computing/compute-resources.ipynb
Outdated
Show resolved
Hide resolved
learning/courses/integrating-quantum-and-high-performance-computing/compute-resources.ipynb
Outdated
Show resolved
Hide resolved
| "\n", | ||
| "</summary>\n", | ||
| "<Accordion>\n", | ||
| "<AccordionItem title=\"How many qubits are in the circuit below? \">\n", |
There was a problem hiding this comment.
@0sophy1 a link (even to an image) will not render in the accordion - I suggest either putting the image directly below the accordion, or directly above (and change the language to "how many qubits are in the circuit above?")
There was a problem hiding this comment.
Hi Abby, thanks for the heads‑up. I saw that the preview can render the image in the title, so I thought we could use it there.
learning/courses/quantum-business-foundations/quantum-computing-fundamentals.mdx
Outdated
Show resolved
Hide resolved
learning/courses/quantum-business-foundations/quantum-computing-fundamentals.mdx
Outdated
Show resolved
Hide resolved
learning/courses/quantum-diagonalization-algorithms/krylov.ipynb
Outdated
Show resolved
Hide resolved
learning/courses/quantum-diagonalization-algorithms/krylov.ipynb
Outdated
Show resolved
Hide resolved
…uting/compute-resources.ipynb Co-authored-by: abbycross <across@us.ibm.com>
…uting/compute-resources.ipynb Co-authored-by: abbycross <across@us.ibm.com>
…uting/compute-resources.ipynb Co-authored-by: abbycross <across@us.ibm.com>
Co-authored-by: abbycross <across@us.ibm.com>
…g-fundamentals.mdx Co-authored-by: abbycross <across@us.ibm.com>
…g-fundamentals.mdx Co-authored-by: abbycross <across@us.ibm.com>
Co-authored-by: abbycross <across@us.ibm.com>
Co-authored-by: abbycross <across@us.ibm.com>
| "\n", | ||
| "</summary>\n", | ||
| "<Accordion>\n", | ||
| "<AccordionItem title=\"Please use [Coulomb law](https://en.wikipedia.org/wiki/Coulomb%27s_law) and [atomic unit](https://en.wikipedia.org/wiki/Atomic_units) to make sure you get the value in `Hartree`.\">\n", |
There was a problem hiding this comment.
Links will need to be removed. Maybe include them under the image instead?
learning/modules/quantum-mechanics/exploring-uncertainty-with-qiskit.ipynb
Outdated
Show resolved
Hide resolved
learning/modules/quantum-mechanics/get-started-with-qiskit.ipynb
Outdated
Show resolved
Hide resolved
|
great work, thanks @0sophy1! One thing I noticed that maybe you and @christopherporter1 can decide which one you like better: When there are several questions one after the other, the spacing between them renders differently depending on whether you group all of them within the same It's up to you stylistically which you like better, and then we should be consistent throughout. We also want to avoid mixing both, like what happened in this one: |
|
One last comment: I noticed that the |
Co-authored-by: abbycross <across@us.ibm.com>
Co-authored-by: abbycross <across@us.ibm.com>
Co-authored-by: abbycross <across@us.ibm.com>
…qiskit.ipynb Co-authored-by: abbycross <across@us.ibm.com>
Hi Abby, I did my best to edit everything into a more unified style (similar to the first option). I’m sorry if I missed anything. Personally, I prefer the first style. |






Fixes #[4913]
This PR converts all
<details>/<summary>HTML tags to<Accordion>/<AccordionItem>components in learning contents and removed pre-course surveys