Conversation
diego-plan9
left a comment
There was a problem hiding this comment.
Thanks @joseluu ! This would require a new version of platform-services-python-sdk that contains your fix to be released before working, right?
| """Discover account for ibm_cloud and ibm_quantum_platform channels.""" | ||
| account = None | ||
| verify_ = verify or True | ||
| verify_ = verify |
There was a problem hiding this comment.
Is this change intentional? While the verify flag in the signature of this function (and others) could use a revision for ensuring it is always a bool, I believe this line mostly coerces None into an actual boolean and should still be kept for preserving previous behavior.
…m-services-python-sdk
Thanks to a suggestion from the |
diego-plan9
left a comment
There was a problem hiding this comment.
Thanks - unfortunately, a related PR was started in the meantime, #2607, which provides a more comprehensive fix (extending the ssl verification flag to calls to other services, and includes handling of the proxy arguments too). As it is a superset of this PR, I'm inclined to focus on landing #2607 if it gets into mergeable state before the next release.
|
Thanks again - closing as #2607 was merged. |
PR summary
fixes #2592
This is a 3 lines change:
Current vs new behavior
disabling host verification now works
Does this PR introduce a breaking change?