Skip to content

host verification disable now works#2593

Closed
joseluu wants to merge 2 commits intoQiskit:mainfrom
joseluu:main
Closed

host verification disable now works#2593
joseluu wants to merge 2 commits intoQiskit:mainfrom
joseluu:main

Conversation

@joseluu
Copy link
Copy Markdown

@joseluu joseluu commented Feb 6, 2026

PR summary

fixes #2592
This is a 3 lines change:

  • GlobalCatalogV1 object now carries a disable_ssl_verification flag
  • GlobalSearchV2 now initializes the BaseService parent with the proper value of disable_ssl_verification

Current vs new behavior

disabling host verification now works

Does this PR introduce a breaking change?

  • Yes
  • No

Copy link
Copy Markdown
Member

@diego-plan9 diego-plan9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joseluu ! This would require a new version of platform-services-python-sdk that contains your fix to be released before working, right?

"""Discover account for ibm_cloud and ibm_quantum_platform channels."""
account = None
verify_ = verify or True
verify_ = verify
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intentional? While the verify flag in the signature of this function (and others) could use a revision for ensuring it is always a bool, I believe this line mostly coerces None into an actual boolean and should still be kept for preserving previous behavior.

@joseluu
Copy link
Copy Markdown
Author

joseluu commented Feb 27, 2026

Thanks @joseluu ! This would require a new version of platform-services-python-sdk that contains your fix to be released before working, right?

Thanks to a suggestion from the platform-services-python-sdk maintainers, I just made a second commit avoiding the dependency on any platform-services-python-sdk modification.

Copy link
Copy Markdown
Member

@diego-plan9 diego-plan9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - unfortunately, a related PR was started in the meantime, #2607, which provides a more comprehensive fix (extending the ssl verification flag to calls to other services, and includes handling of the proxy arguments too). As it is a superset of this PR, I'm inclined to focus on landing #2607 if it gets into mergeable state before the next release.

@diego-plan9
Copy link
Copy Markdown
Member

Thanks again - closing as #2607 was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

going through a proxy and disabling host verification fails

2 participants