Add catalog interface tests and InMemoryCatalog example#30
Merged
Conversation
This PR adds comprehensive tests for the catalog interface and includes the InMemoryCatalog example implementation: Tests (tests/catalog/): - test_serialization.py: Round-trip tests for all catalog dataclasses - test_catalog_interface.py: Tests for CatalogInterface ABC and ReadOnlyCatalogInterface DDL rejection - test_integration.py: End-to-end tests using InMemoryCatalog for catalog operations (attach/detach, schemas, tables, views, versioning) InMemoryCatalog (vgi/examples/catalog.py): - In-memory catalog implementation for testing - Supports DDL operations (create/drop/rename for schemas, tables, views) - UUID-based attach_id generation - Catalog versioning on modifications - Entry point: vgi-example-catalog-worker 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Files (tests/catalog/)
test_serialization.py: Round-trip tests for all catalog dataclasses (CatalogAttachResult, SchemaInfo, TableInfo, ViewInfo, FunctionInfo, ScanFunctionResult)test_catalog_interface.py: Tests for CatalogInterface ABC, default implementations, and ReadOnlyCatalogInterface DDL rejectiontest_integration.py: End-to-end tests using InMemoryCatalogInMemoryCatalog (vgi/examples/catalog.py)
vgi-example-catalog-workerTest Coverage
Test plan
🤖 Generated with Claude Code