-
Notifications
You must be signed in to change notification settings - Fork 1.4k
V2 – chore(eslint): migrate to oxlint, oxfmt #8282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kenzo-Wada
wants to merge
8
commits into
QwikDev:build/v2
Choose a base branch
from
Kenzo-Wada:chore/migrate-oxc
base: build/v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0d1a974
chore: migrate to oxlint, oxfmt
Kenzo-Wada 0fff82d
chore: remove unnessesary ignores
Kenzo-Wada 4e03c4d
chore: remove prettier fallback
Kenzo-Wada 78fe7a4
chore: added no-focus-tests
Kenzo-Wada 1801fc8
chore: added rule of restricted imports
Kenzo-Wada 464c0df
chore: add lint-staged
Kenzo-Wada 5fc3152
chore: remove deny-warnings
Kenzo-Wada f9a6546
chore: update dependencies
Kenzo-Wada File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Ignore patterns | ||
| **/**.api.md | ||
| **/*.log | ||
| **/.DS_Store | ||
| pnpm-lock.yaml | ||
| dist | ||
| dist-dev | ||
| lib | ||
| target | ||
| node_modules | ||
| tsconfig.tsbuildinfo | ||
| packages/docs/public/repl/repl-sw.js* | ||
| packages/*/lib | ||
| packages/*/dist | ||
| packages/*/server | ||
| packages/docs/src/routes/api | ||
| packages/insights/drizzle | ||
| packages/insights/.netlify | ||
| packages/insights/scripts | ||
| packages/insights/**/*.gen.d.ts | ||
| **/q-insights.json | ||
| packages/docs/public/builder |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| { | ||
| "$schema": "https://oxc.rs/schemas/oxfmt.json", | ||
| "jsdocPreferCodeFences": true, | ||
| "tsdoc": true, | ||
| "printWidth": 100, | ||
| "tabWidth": 2, | ||
| "useTabs": false, | ||
| "semi": true, | ||
| "singleQuote": true, | ||
| "trailingComma": "es5", | ||
| "experimentalSortPackageJson": false, | ||
| "overrides": [ | ||
| { | ||
| "files": ["packages/docs/**"], | ||
| "options": { | ||
| "printWidth": 80 | ||
| } | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,134 @@ | ||
| { | ||
| "$schema": "https://raw.githubusercontent.com/oxc-project/oxc/main/npm/oxlint/configuration_schema.json", | ||
| "plugins": ["jsdoc", "import", "unicorn", "vitest"], | ||
| "rules": { | ||
| "no-console": ["error", { "allow": ["warn", "error"] }], | ||
| "curly": "error", | ||
| "no-new-func": "error", | ||
| "no-unused-vars": "off", | ||
| "no-unused-expressions": "off", | ||
| "no-control-regex": "off", | ||
| "no-shadow-restricted-names": "off", | ||
| "unicorn/no-empty-file": "off", | ||
| "unicorn/no-new-array": "off", | ||
| "jsdoc/check-property-names": "off", | ||
| "jsdoc/check-tag-names": "off", | ||
| "jsdoc/require-property": "off", | ||
| "jsdoc/require-yields": "off", | ||
| "vitest/expect-expect": "off", | ||
| "vitest/no-disabled-tests": "off", | ||
wmertens marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "vitest/no-focused-tests": "error", | ||
| "vitest/valid-title": "off", | ||
| "vitest/warn-todo": "off", | ||
| "jest/expect-expect": "off", | ||
wmertens marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "jest/no-disabled-tests": "off", | ||
| "jest/no-focused-tests": "error", | ||
| "jest/valid-title": "off", | ||
| "jest/no-conditional-expect": "off", | ||
| "jest/valid-describe-callback": "off", | ||
| "jest/no-export": "off", | ||
| "import/default": "off", | ||
| "unicorn/prefer-string-starts-ends-with": "off", | ||
| "no-eval": "off", | ||
| "no-unsafe-optional-chaining": "off", | ||
| "unicorn/no-unnecessary-await": "off", | ||
| "unicorn/no-invalid-remove-event-listener": "off", | ||
| "jest/valid-expect": "off", | ||
| "vitest/no-conditional-tests": "off" | ||
| }, | ||
| "overrides": [ | ||
| { | ||
| "files": ["packages/docs/**/*.ts", "packages/docs/**/*.tsx"], | ||
| "rules": { | ||
| "no-console": "off", | ||
| "curly": "off" | ||
| } | ||
| }, | ||
| { | ||
| "files": ["packages/qwik/src/server/**/*.ts"], | ||
| "rules": { | ||
| "no-restricted-imports": ["error", { | ||
| "patterns": [ | ||
| { | ||
| "group": ["packages/*"], | ||
| "message": "Absolute imports are not allowed." | ||
| }, | ||
| { | ||
| "group": ["../**"], | ||
| "message": "Relative imports are not allowed." | ||
| } | ||
| ] | ||
| }] | ||
| } | ||
| }, | ||
| { | ||
| "files": ["packages/qwik/src/server/qwik-copy.ts"], | ||
| "rules": { | ||
| "no-restricted-imports": "off" | ||
| } | ||
| }, | ||
| { | ||
| "files": ["packages/qwik/src/server/qwik-types.ts"], | ||
| "rules": { | ||
| "no-restricted-imports": ["error", { | ||
| "patterns": [ | ||
| { | ||
| "group": ["packages/*"], | ||
| "message": "Absolute imports are not allowed.", | ||
| "allowTypeImports": true | ||
| }, | ||
| { | ||
| "group": ["../**"], | ||
| "message": "Relative imports are not allowed.", | ||
| "allowTypeImports": true | ||
| } | ||
| ] | ||
| }] | ||
| } | ||
| } | ||
| ], | ||
| "ignorePatterns": [ | ||
| "**/.history", | ||
| "**/.vscode", | ||
| "**/dist", | ||
| "**/dist-dev", | ||
| "**/lib", | ||
| "**/node_modules", | ||
| "**/tsc-out", | ||
| "**/external", | ||
| "**/*.log", | ||
| "**/etc", | ||
| "**/target", | ||
| "**/temp", | ||
| "**/tsdoc-metadata.json", | ||
| "**/.DS_Store", | ||
| "**/*.mp4", | ||
| "scripts", | ||
| "**/server/**/*.js", | ||
| "**/*.tsbuildinfo", | ||
| "packages/docs/api", | ||
| "packages/docs/public/repl/repl-sw.js*", | ||
| "packages/docs/src/routes/examples/apps", | ||
| "packages/docs/src/routes/playground/app", | ||
| "packages/docs/src/routes/tutorial", | ||
| "packages/qwik/src/optimizer/core/src/fixtures", | ||
| "packages/qwik/bindings", | ||
| "packages/qwik-labs/lib", | ||
| "packages/qwik-labs/lib-types", | ||
| "packages/qwik-labs/vite", | ||
| "packages/insights/drizzle.config.ts", | ||
| "packages/insights/panda.config.ts", | ||
| "packages/qwik/src/napi", | ||
| "starters/apps/base", | ||
| "starters/apps/library", | ||
| "starters/templates", | ||
| "**/vite.config.ts", | ||
| "packages/qwik-labs", | ||
| "packages/insights", | ||
| "**/eslint.config.mjs", | ||
| "**/eslint.config.js", | ||
| ".changeset", | ||
| "packages/docs/public/builder", | ||
| "packages/eslint-plugin-qwik/tests" | ||
| ] | ||
| } | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.