Skip to content

docs: style fixes#8519

Open
Varixo wants to merge 14 commits intobuild/v2from
v2-docs-fixes
Open

docs: style fixes#8519
Varixo wants to merge 14 commits intobuild/v2from
v2-docs-fixes

Conversation

@Varixo
Copy link
Copy Markdown
Member

@Varixo Varixo commented Apr 3, 2026

No description provided.

@Varixo Varixo requested a review from a team as a code owner April 3, 2026 15:21
@Varixo Varixo added the V2 label Apr 3, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 3, 2026

⚠️ No Changeset found

Latest commit: 9f5b7ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@maiieul maiieul moved this to Waiting For Review in Qwik Development Apr 3, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 3, 2026

Open in StackBlitz

@qwik.dev/core

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8519

@qwik.dev/router

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8519

eslint-plugin-qwik

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8519

create-qwik

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8519

@qwik.dev/optimizer

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/optimizer@8519

commit: 9f5b7ba

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ❌ Failed (View Log) 9f5b7ba

const getButtonClasses = (variant: ButtonVariant) => ({
faceClass: button[variant],
shadowClass: variant === 'primary' ? button.primaryShadow : button.secondaryShadow,
shadowClass:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe better to have regular if here?


useVisibleTask$(
() => {
toggleNavbar();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After scrolled refresh the navbar was wrong

@Varixo Varixo requested a review from a team as a code owner April 5, 2026 19:03
@Varixo Varixo force-pushed the v2-docs-fixes branch 4 times, most recently from 8e16bb8 to b129f41 Compare April 8, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Waiting For Review

Development

Successfully merging this pull request may close these issues.

3 participants