Conversation
After store.reorg() the blocks_hash_ts vector is not truncated, so tip_height/tip_hash/block_hash still expose the reorged block. The test asserts the current (wrong) behaviour with a TODO marking what the correct assertions should be. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
During a reorg, store.reorg() rolled back the persistent state but blocks_hash_ts was not truncated. This left a window where tip_hash / block_hash still returned the reorged block's data. Extract State::handle_reorg() that atomically truncates blocks_hash_ts and calls store.reorg(), and use it from the block-indexing thread. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The retain loop over outpoints_created called txids.contains() for each entry, making it O(n*m) where n is outpoints and m is removed txids. Collecting txids into a HashSet first reduces this to O(n+m). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.