Feature/item stacking#1501
Open
worldreboot wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds stackable inventory items for containers, addressing #1258.
Each stackable item type can define its own per-slot stack limit. Stacked items keep their hidden
item instances in an internal stack container, support adding/removing items from the bundle, merge
when dropped onto matching stacks, and show stack counts in container UI.
This PR includes:
This PR does not broadly convert every stackable candidate item. Steel sheets are the initial
configured stackable item.
PR checklist
Pictures/Videos
stacking.webm
Testing
Automated tests run:
Focused EditMode stacking suite passed:
EditorTests.StackableTestsEditorTests.ContainerTestsEditorTests.ItemDisplayTestsMultiplayer PlayMode test passed:
SS3D.Tests.ClientStackingActions.ClientCanStackSteelSheetsInsideToolboxManual/expected behavior to test:
2.Networking checklist
Changes
Major changes:
Stackablesupport for item stacks using a hidden internal stack container.Stackablecomponent.SteelSheet.prefabas the first stackable item.Test/support changes:
labels.
Known notes:
Related issues/PRs
Closes #1258