Skip to content

pkg/mpaland-printf: wrap putc() and fputc()#21828

Merged
maribu merged 1 commit intoRIOT-OS:masterfrom
maribu:pkg/mpaland-printf/wrap-putc-fputc
Oct 29, 2025
Merged

pkg/mpaland-printf: wrap putc() and fputc()#21828
maribu merged 1 commit intoRIOT-OS:masterfrom
maribu:pkg/mpaland-printf/wrap-putc-fputc

Conversation

@maribu
Copy link
Copy Markdown
Member

@maribu maribu commented Oct 29, 2025

Contribution description

Those two functions have previously been overlooked. This commit adds the missing wrappers.

Testing procedure

Fixes #21805 (comment)

Issues/PRs references

#21805 (comment)

Those two functions have previously been overlooked. This commit adds
the missing wrappers.
@maribu maribu requested a review from benpicco October 29, 2025 17:16
@github-actions github-actions bot added the Area: pkg Area: External package ports label Oct 29, 2025
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 29, 2025
@crasbe crasbe added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label Oct 29, 2025
@maribu maribu enabled auto-merge October 29, 2025 18:06
@riot-ci
Copy link
Copy Markdown

riot-ci commented Oct 29, 2025

Murdock results

✔️ PASSED

69c6627 pkg/mpaland-printf: wrap putc() and fputc()

Success Failures Total Runtime
10552 0 10552 12m:00s

Artifacts

@maribu maribu added this pull request to the merge queue Oct 29, 2025
Merged via the queue into RIOT-OS:master with commit 59af2e4 Oct 29, 2025
28 checks passed
@Teufelchen1
Copy link
Copy Markdown
Contributor

Can you explain to me, how that is fixing the issue?

@maribu maribu deleted the pkg/mpaland-printf/wrap-putc-fputc branch October 30, 2025 09:59
@maribu
Copy link
Copy Markdown
Member Author

maribu commented Oct 30, 2025

The affected test app used putc() to write to output, but that was not implemented with mpaland-printf yet. This adds the missing implementation.

So in master a call to putc() would still link to the newlib implementation - but different stdio implementations don't mix well.

@Teufelchen1
Copy link
Copy Markdown
Contributor

oooohhhh ah, now it's obvious. Thanks.

@benpicco benpicco added this to the Release 2025.10 milestone Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants