increase KERNARG_BUFFER_SIZE from 512 to 4k#1377
Merged
scchan merged 2 commits intoJan 29, 2020
Merged
Conversation
Collaborator
Author
|
Since this PR also reduces the asyncops size, it could replace #1261 . |
Contributor
|
Justification for all the numbers is needed. |
Collaborator
Author
|
Collaborator
Author
|
@emankov The most important change in this PR is the increase in the default kernarg buffer size. If needed, would such a change be acceptable without the other changes? |
Contributor
|
@jeffdaily, thank you for explanation. Could you please add just a few words in comments? |
Collaborator
Author
scchan
requested changes
Jan 27, 2020
Decrease HCC_ASYNCOPS_SIZE from 16k to 1k.
f0e2b40 to
d6b79a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decrease HCC_ASYNCOPS_SIZE from 16k to 1k.
HCC_KERNARG_BUFFER_SIZE is now an environment variable.
HCC_KERNARG_POOL_SIZE is now an environment variable.