Skip to content

Add M3U format - #3998

Open
boyska wants to merge 10 commits into
RSS-Bridge:masterfrom
boyska:m3u-format
Open

Add M3U format#3998
boyska wants to merge 10 commits into
RSS-Bridge:masterfrom
boyska:m3u-format

Conversation

@boyska

@boyska boyska commented Mar 5, 2024

Copy link
Copy Markdown

fixes #3995

this is especially useful for podcasts.

@boyska
boyska marked this pull request as ready for review March 5, 2024 18:55
@boyska boyska changed the title M3u format Add M3U format Mar 5, 2024
@dvikan

dvikan commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

pls put all code inside a single class

@boyska

boyska commented Mar 7, 2024

Copy link
Copy Markdown
Author

pls put all code inside a single class

can I ask you what's the rationale for this? While I can see how moving parse_duration() inside a class can enhance encapsulation (did that in 2597cff), I think that exploding M3uItem into a set of methods and private variables will result in code that is harder to read, understand and maintain.

But I'm not particularly good at PHP, so maybe you have suggestions for how to keep the code well encapsulated, while having the same benefit of "all code in a single class".

@dvikan

dvikan commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

php does not have modules like python does.

your previous function parse_duration was defined in global namespace.

also it's my subjective preference to have code closer together and not spread out.

i'd prefer you drop M3uItem and inline all code inside M3uFormat.

@boyska

boyska commented Mar 7, 2024

Copy link
Copy Markdown
Author

i'd prefer you drop M3uItem and inline all code inside M3uFormat.

like this? 266a6c0

if you think this is still not right, just tell me: I'm eager to learn :)

@boyska

boyska commented Mar 21, 2024

Copy link
Copy Markdown
Author

gentle ping :)

@dvikan

dvikan commented Mar 31, 2024

Copy link
Copy Markdown
Contributor

yes still thinking about this.

@dvikan

dvikan commented Jan 3, 2025

Copy link
Copy Markdown
Contributor

sorry for the long wait. shall we restart this?

can you explain what is M3U?

can you give an example?

how can I take a M3U format and test whether it works okay? which software consumes M3U?

@boyska

boyska commented Jan 4, 2025 via email

Copy link
Copy Markdown
Author

@dvikan

dvikan commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

closing because old. let me know if there is still interest

@dvikan dvikan closed this Aug 1, 2026
@boyska

boyska commented Aug 2, 2026

Copy link
Copy Markdown
Author

closing because old. let me know if there is still interest

actually, yes :)
if there's anything I can do to help you on this, just let me know.

@dvikan dvikan reopened this Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New format: M3U playlist

2 participants