add an option in handleyoutube for "selfhosting" youtube iframes - #4942
Open
Tone866 wants to merge 14 commits into
Open
add an option in handleyoutube for "selfhosting" youtube iframes#4942Tone866 wants to merge 14 commits into
Tone866 wants to merge 14 commits into
Conversation
Contributor
|
sorry mate, this code is too hacky. should be in a template file in templates folder, and a new action also this would add extra traffic to rss-bridge instance, so maybe add a config bool for it |
Contributor
Author
|
Ok, I moved it to templates and added an extra config bool for it. |
Contributor
|
im sorry dude but the files in templates folder are not supposed to be directly accessible. They are rendered by php, then server to client |
Contributor
Author
|
You told me to move it in the templates folder? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like mentioned in #4921 youtube iframes are broken.
There is already a fix in form of displaying the thumbnail with an link below, but with this solution we are moving the iframe from youtube to our the rss-bridge instance, which allows us to display the thumnail again.
example:
>