fix(lookup): resolve lower tiers outside caller namespace - #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
struct pathd_path()+kern_path(), which incorrectly re-enters the calling task's mount namespaceRoot cause
Plex runs inside an LXC container that sees the merged SmoothFS bind mount but intentionally does not see SmoothNAS's host-only backing-tier mountpoints. The existing resolver rendered a pinned lower path into a pathname and passed it to
kern_path(). That lookup starts in the caller's mount namespace, so files present only on a lower tier returnedENOENTuntil a host lookup warmed the union dentry.The fix uses
vfs_path_lookup()relative to the already-pinned lower dentry and mount.Validation
git diff --check7.0.11-smoothkerneltier_spill_mount_namespace_lookup.shregression test fails against released SmoothFS v0.2.23 before this fix